Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embedded login dialog following UX review #362

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

richard-cox
Copy link
Member

Summary

Fixes #359

Occurred changes and/or fixed issues

  • add text to clusters list refresh button
  • make the login dialog more rancher login like
    • Don't use a generic prompt or tabs
    • allow user to toggle between local and dex options

@richard-cox richard-cox added this to the v1.11.0 milestone Nov 14, 2023
@richard-cox richard-cox self-assigned this Nov 14, 2023
torchiaf
torchiaf previously approved these changes Nov 16, 2023
Copy link
Contributor

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved.

@torchiaf
Copy link
Contributor

The Auth Provider option is available even if my user is not enable to Dex login, this is because the oidcEnabled flag is true:

image

@richard-cox richard-cox merged commit 0a76d5c into epinio:main Nov 16, 2023
5 checks passed
@richard-cox richard-cox deleted the embedded-login-changes branch November 16, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] Improve embedded ui log in UX
2 participants