Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update discrete_reporting_prob #109

Closed
Tracked by #92
seabbs opened this issue Jul 8, 2022 · 1 comment · Fixed by #113
Closed
Tracked by #92

Update discrete_reporting_prob #109

seabbs opened this issue Jul 8, 2022 · 1 comment · Fixed by #113
Assignees
Labels

Comments

@seabbs
Copy link
Collaborator

seabbs commented Jul 8, 2022

After discussion (between @adrian-lison and myself) we concluded that the discrete reporting probability should be normalised to 1 by putting 1 minus the cumulative probability density on the last permissible max delay rather than the current default of normalising. This should be added as an option in the stan code but hard coded in the actual model as no other use case makes sense currently.

Before merging we need to fit against the example and README to check performance.

https://github.com/epiforecasts/epinowcast/blob/a5616b15857d790eced0f1289b498d42fa0ca6d7/inst/stan/functions/discretised_reporting_prob.stan#L3

@seabbs seabbs mentioned this issue Jul 8, 2022
21 tasks
@adrian-lison adrian-lison self-assigned this Jul 12, 2022
@adrian-lison adrian-lison linked a pull request Jul 12, 2022 that will close this issue
@seabbs
Copy link
Collaborator Author

seabbs commented Jul 14, 2022

Done in #113

@seabbs seabbs closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants