Collection: find

[hrasoa]

var collection = new Epitome.Collection([
{
User: {name: 'Bob', id: 2}
},
{
User: {name: 'Angry Bob', id: 3}
}
]);

console.log(collection, collection.find('[User.name]'));

This actually doesn't work :( I am retrieving datas from CakePhp.

[krsmedlund]

I think you have misunderstood how this works, [User.name] isnt a valid selector for your data, you only have 2 attributes, id and name, you are picking all models that has the "User.name" attribute set,

console.log(collection, collection.find("[name]"));

will get all models with the name attribute, which is what you want.

console.log(collection, collection.find("[name=Bob]"));

will return only the first entry

[hrasoa]

Hi,
Thanks for the replay. I tried to use "[name=Bob]" or "[name]" as selector but it still returns an empty array.

[DimitarChristoff]

yes, basically, you have an object that notates as `User.name' whereas the simple property selector is for properties at the level of User.

you can do a custom property getter 'name' in your model prototype that returns user.name or you can do

var myCollection = new Class({

    Extends: Epitome.Collection,

    findByName: function(who) {
        return this.filter(function(model){
            return model.get('User').name == who; 
        });
    }
});


var collection = new myCollection([{
User: {name: 'Bob', id: 2}
},
{
User: {name: 'Angry Bob', id: 3}
}
]);

console.log(collection.findByName('Bob'));

I like the idea of being able to search deep object properties but the problem is, there is no guarantee that what people put in the model is just a plain / primitive property and not a function or a Class or whatever. Also, the . notation is just sugar. for example, if you did:

model.set('user.name', 'bob');

this may make sense from your data standpoint as you want your json to actually send 'user.name': 'bob' and not create a deep object. I work with some protocols / apis that have all sorts of weird chars.

If there can be a rule to be defined here as to how to serialize the model and to apply a deep obj property searach, i would be very happy to do so.

mootools/mootools-core#2191 was a similar sort of thing which allowed you to do:

obj.get('foo.bar.name'); // or .set

it did not get pulled into mootools-core. it may end up at mootools-more.

it would probably be trivial to extend the selector engine to do that so its like .find('User[name=Bob]') - i will look at it shortly.

[hrasoa]

ok thanks, i'll wait for this.

[DimitarChristoff]

it's not ready yet, though in your case it seems to work. got some issues I need to fix but working on it. expectation for .find('User') being the same as .find('[User]') is not passing yet. will commit more today or tomorrow.

[DimitarChristoff]

seems to now work - in the branch bug-fix-5 - I won't merge with master until I am certain it's fine and write 1 more test but at a first reading, .find('User') will pass as well as .find('User[name=Bob]'). let me know if it works, see updated collection-demo.js and view collection.html to test

[hrasoa]

Hi, this works great. Thanks !