-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow C++ code sharing #150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratikunterwegs
added
New feature
New feature or request
Cleanup
Clean up files or code for readability.
labels
Feb 16, 2023
pratikunterwegs
force-pushed
the
feature/share-cpp
branch
from
February 16, 2023 14:04
e86f23e
to
1be830b
Compare
pratikunterwegs
force-pushed
the
feature/share-cpp
branch
from
February 16, 2023 14:22
1be830b
to
ecff300
Compare
pratikunterwegs
force-pushed
the
feature/share-cpp
branch
from
February 23, 2023 12:35
ecff300
to
a9161ec
Compare
pratikunterwegs
force-pushed
the
feature/share-cpp
branch
from
March 9, 2023 10:30
daf50ff
to
a9161ec
Compare
I've forcibly reset the branch to remove the final two commits which had moved the contact matrix processing (for the small speed boost) to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #146, and allows the {finalsize} C++ code to be shared with other Rcpp packages, such as {epidemics}. This is a potential precursor to fixing #68, but that issue is not tackled here.
Using {finalsize} headers in a new package is relatively easy:
// [[Rcpp::depends(finalsize)]]
in a source file,#include <finalsize.h>
.