Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R implementation of final size with susceptibility groups #42
R implementation of final size with susceptibility groups #42
Changes from 19 commits
dea3e87
1d16945
f0da83d
99ee281
14ff0d5
909e339
fc9da5c
eee0be6
55d6c50
3d4ea27
bfe9cbe
990d5d8
f1428ae
8d4a8f1
25b855e
8715575
42127c0
475c426
3c90ab8
b2f80d3
d46f915
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on the readability: here
c_matrix
is named, could also potentially named_vector
,psusc
andsusc
to make the mapping of age groups explicit between objects, more personal preference than anything.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the
c_matrix
comes fromsocialmixr::polymod
and carries over those naming conventions. I'm not sure why thed_vector
, which also comes from thepolymod
data, is not named. Naming rows and columns for clarity is a good idea, but it's unclear where the naming should happen (insocialmixr
? infinalsize
?), and what should happen if none of the elements has names at all. I'm leaving this for now but it's worth perhaps opening an issue about it.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.