Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #44

Merged
merged 2 commits into from
Nov 30, 2019
Merged

Fixes #44

merged 2 commits into from
Nov 30, 2019

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Nov 27, 2019 •
edited
Loading

  • Return consistent results equal(x, y) == equal(y, x).
  • Return false for pseudo Map, Set and TypedArray objects.

@streamich
fix: 🐛 improve TypeArray checks
758e457 
(1) run test suite with revered arguments, too; (2) check of object
"constructor" prop; (3) simplify TypeArray check
@streamich
fix: 🐛 Set is not equal to pseudo-Set
aca6575
@streamich streamich changed the title Various Fixes Nov 27, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling aca6575 on streamich:various into 299fb32 on epoberezkin:master.

@epoberezkin epoberezkin merged commit aca6575 into epoberezkin:master Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@streamich @coveralls @epoberezkin