Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Heatmap Bucketing #41

Closed
2 tasks done
rsandor opened this issue Jun 10, 2014 · 0 comments
Closed
2 tasks done

Incorrect Heatmap Bucketing #41

rsandor opened this issue Jun 10, 2014 · 0 comments

Comments

@rsandor
Copy link
Collaborator

rsandor commented Jun 10, 2014

The _prepareEntry method of Epoch.Time.Heatmap is responsible for transforming a sparse histogram into the correct number of buckets (buckets option) given a range (bucketRange option). The way we currently do this is pretty lazy and generally considered to be "jank" (technical term). This can have some very weird effects on the graphical output of the plot, here's an example:

screenshot 2014-06-10 14 56 27

This should be a plot of a normal distribution stretched over the range [0, 100) across 45 buckets. Clearly there are some weird numerical errors cropping up due to the so-called "jankness" of our bucketing routine.

Here's what needs to be done:

  • Create a test in the tests/real-time/heatmap.html that reproduces the beahvior
  • Implement a better _prepareEntry method that does not suffer from this problem
@rsandor rsandor added this to the Release 0.5.0 (beta) milestone Jun 10, 2014
@rsandor rsandor added the bug label Jun 10, 2014
rsandor added a commit that referenced this issue Jun 23, 2014
Fixes #41; Fixed bucketing for the Heat Map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant