Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genre split by slash #417

Closed
splintering opened this issue Feb 13, 2024 · 7 comments
Closed

Genre split by slash #417

splintering opened this issue Feb 13, 2024 · 7 comments
Milestone

Comments

@splintering
Copy link

I tried to read through previous issues to find out what is the policy for splitting tags, but I could not really find a definitive answer. So sorry if this is a duplicate question in any way.

I am just trying out LMS (recommended by Tolriq from Symfonium) running the current docker image. I have genre tags that look like this: "Rock/Pop/Indie". This is supposed to be a single genre, but LMS splits this into three genre "Rock", "Pop", "Indie". Is this definitely intended like this?

@epoupon
Copy link
Owner

epoupon commented Feb 13, 2024

Ah, I am currently working on improving this!
Yes, LMS has some hardcoded delimiters for genre (including /)
I plan to expose these delimiters in the settings panel. For now they would be used for every tag (artist, genre, mood, etc )
The idea will be to expose the extra tag delimiters to be used, but no split will be done if at least one multi-valued tag is spotted in the file.

@splintering
Copy link
Author

Ok, having the option to configure the delimiters would be great :-) With the genres, this is only my own custom problem. But e.g. with artists there are some well-known issues (the "AC/DC" problem). So it makes sense to have this configurable.

I will keep an eye on this. And thank you for your immediate response!

@Tolriq
Copy link

Tolriq commented Feb 13, 2024

BTW delimiters should be strings and not just char.
" / " as a delimiter would be different from "/" and solve a few problems like AC/DC ;)

@epoupon
Copy link
Owner

epoupon commented Feb 13, 2024

Yes but then it would not split its Rock/Pop/Indie genres.
Basically, we want to set custom string delimiters, per tag type.
That's some significant effort to make a decent UI to handle these badly tagged files.

@Tolriq
Copy link

Tolriq commented Feb 13, 2024

Yes but then it would not split its Rock/Pop/Indie genres.

That's the point and why I just mention that delimiters should be strings with multiple chars like " / " and not just single char delimiters.

My default artist separator is artistSeparators = arrayOf(" / ", " , ", ";", " feat. ", " ft. ") and the genre genreSeparators = arrayOf(" / ", ",", ";", " & ") again the " & " is not just "&".

@epoupon
Copy link
Owner

epoupon commented Feb 13, 2024

And what about moods, languages, release types, labels, etc.?

@Tolriq
Copy link

Tolriq commented Feb 13, 2024

arrayOf("|", "#", ";", ":", "/") most of the time. But if it's configurable it's ok, just make it configurable to support strings with spaces not just a single char.

@epoupon epoupon added this to the v3.50.0 milestone Mar 1, 2024
@epoupon epoupon closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants