Clicking two times at scan button (before the first one finish) causes a crash

[stkw0]

By mistake I clicked two times very fast the scan button, so the first scan was not finished the time I clicked again, which produced a crash with the next message:

/usr/lib/gcc/x86_64-pc-linux-gnu/13/include/g++-v13/optional:486: constexpr const _Tp& std::_Optional_base_impl<_Tp, _Dp>::_M_get() const [with _Tp = lms::scanner::ScanStepStats; _Dp = std::_Optional_base<lms::scanner::ScanStepStats, true, true>]: Assertion 'this->_M_is_engaged()' failed.
Magick: abort due to signal 6 (SIGABRT) "Abort"...

[epoupon]

Hello!
Thanks for reporting. Is this with v3.53.1?
Looks like you compile in debug mode?

[stkw0]

Nop, I compile in release mode and O2. Is there some non-standard debugging variable that defaults to true?

It is with v3.53.0

[epoupon]

Ok, this is strange to have an assertion in cmake "Release" build mode (NDEBUG should be defined to remove them. it is explicitely added in

lms/CMakeLists.txt

Line 51 in a7f4672

if (NOT CMAKE_BUILD_TYPE STREQUAL "Debug")

)

[stkw0]

Indeed, NDEBUG is defined: [1/196] /usr/bin/x86_64-pc-linux-gnu-g++ -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DNDEBUG -Dlmscore_EXPORTS -I/var/tmp/portage/media-sound/lms-3.53.0/work/lms-3.53.0/src/libs/core/include -march=native -O2 -pipe -I/usr/include/stb/deprecated -std=gnu++20 -fPIC -Wall -Wextra -pedantic -MD -MT src/libs/core/CMakeFiles/lmscore.dir/impl/ArchiveZipper.cpp.o -MF src/libs/core/CMakeFiles/lmscore.dir/impl/ArchiveZipper.cpp.o.d -o src/libs/core/CMakeFiles/lmscore.dir/impl/ArchiveZipper.cpp.o -c /var/tmp/portage/media-sound/lms-3.53.0/work/lms-3.53.0/src/libs/core/impl/ArchiveZipper.cpp

[stkw0]

Probably the cause is that I'm running the "hardened" profile of my distro in the server, which probably enables assertions and other checks.

[epoupon]

Btw, I see you add this -I/usr/include/stb/deprecated, it should not be needed as LMS makes use of stb resize2 if available (it is really faster than the deprecated resize library)

[stkw0]

Oh, thanks. I will remove it