Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-discs albums appearing once for each disc in the album entries #481

Closed
awsms opened this issue Jun 11, 2024 · 11 comments
Closed

Multi-discs albums appearing once for each disc in the album entries #481

awsms opened this issue Jun 11, 2024 · 11 comments
Milestone

Comments

@awsms
Copy link

awsms commented Jun 11, 2024

Screenshot from 2024-06-11 18-50-34
Screenshot from 2024-06-11 18-50-25
Screenshot from 2024-06-11 18-50-16

Folder structure:

The Dubliners - Complete Collection [FLAC]/
├── CD 1
├── CD 2
├── CD 3
└── CD 4

CD1 Track 1 tags:

  comments: 13
    comment[0]: ARTIST=The Dubliners
    comment[1]: TITLE=The Molly Maguires
    comment[2]: ALBUM=Complete Collection
    comment[3]: DATE=2006
    comment[4]: TRACKNUMBER=01
    comment[5]: GENRE=Celtic
    comment[6]: PERFORMER=The Dubliners
    comment[7]: COMPOSER=
    comment[8]: ALBUMARTIST=The Dubliners
    comment[9]: DISCNUMBER=1
    comment[10]: TOTALDISCS=4
    comment[11]: TOTALTRACKS=20
    comment[12]: COMMENT=

CD2 Track 1 tags:

  comments: 13
    comment[0]: ARTIST=The Dubliners
    comment[1]: TITLE=Free The People
    comment[2]: ALBUM=Complete Collection
    comment[3]: DATE=2009
    comment[4]: TRACKNUMBER=01
    comment[5]: GENRE=Celtic
    comment[6]: PERFORMER=The Dubliners
    comment[7]: COMPOSER=
    comment[8]: ALBUMARTIST=The Dubliners
    comment[9]: DISCNUMBER=2
    comment[10]: TOTALDISCS=4
    comment[11]: TOTALTRACKS=20
    comment[12]: COMMENT=

Is there anything wrong here, or that's expected behaviour?
I found #6, which implies multi-disc albums are well supported on LMS.

@epoupon
Copy link
Owner

epoupon commented Jun 15, 2024

Hello,
Sorry for late response. For now, the only reliable way to group these discs is to use a musicbrainz release id.
If this tag is not present, only the files in the same directory are considered to be part of the same album (and if the name of the album is the same, of course)

@awsms
Copy link
Author

awsms commented Jun 16, 2024

Mhh.. so LMS relies a LOT on MusicBrainz's metadata, as it's also the case for the dupechecker which simply checks a MB track id (and probably other things I haven't found yet).
Shouldn't it be mentioned somewhere in the README? Because I pretty much assumed by reading it setting the same album tag & same album artist for files would group them (like it's the case with navidrome for ex.)

@epoupon
Copy link
Owner

epoupon commented Jun 16, 2024

Yes, it relies a lot on MB (and it is assumed). You are right, this should be better stated in the readme file.
That being said, we can try to improve the fallback behavior to handle more use cases :)

@epoupon epoupon added this to the v3.58.0 milestone Sep 2, 2024
epoupon added a commit that referenced this issue Sep 8, 2024
…plit on sub directories) when musicbrainz ids are not set, fixes #481
@epoupon epoupon closed this as completed Sep 8, 2024
@awsms
Copy link
Author

awsms commented Sep 23, 2024

Hi again! So after pulling the docker image for the latest build, I did a force library rescan.
However, I'm still seeing multi-discs albums as multiple albums instead.
image

@epoupon
Copy link
Owner

epoupon commented Sep 23, 2024

Hello!
What is the layout of the offending album?

@awsms
Copy link
Author

awsms commented Sep 23, 2024

Exactly the same as in the OP, I haven't changed it since:
Folder structure:

The Dubliners - Complete Collection [FLAC]/
├── CD 1
├── CD 2
├── CD 3
└── CD 4

CD1 Track 1 tags:

  comments: 13
    comment[0]: ARTIST=The Dubliners
    comment[1]: TITLE=The Molly Maguires
    comment[2]: ALBUM=Complete Collection
    comment[3]: DATE=2006
    comment[4]: TRACKNUMBER=01
    comment[5]: GENRE=Celtic
    comment[6]: PERFORMER=The Dubliners
    comment[7]: COMPOSER=
    comment[8]: ALBUMARTIST=The Dubliners
    comment[9]: DISCNUMBER=1
    comment[10]: TOTALDISCS=4
    comment[11]: TOTALTRACKS=20
    comment[12]: COMMENT=

CD2 Track 1 tags:

  comments: 13
    comment[0]: ARTIST=The Dubliners
    comment[1]: TITLE=Free The People
    comment[2]: ALBUM=Complete Collection
    comment[3]: DATE=2009
    comment[4]: TRACKNUMBER=01
    comment[5]: GENRE=Celtic
    comment[6]: PERFORMER=The Dubliners
    comment[7]: COMPOSER=
    comment[8]: ALBUMARTIST=The Dubliners
    comment[9]: DISCNUMBER=2
    comment[10]: TOTALDISCS=4
    comment[11]: TOTALTRACKS=20
    comment[12]: COMMENT=

@epoupon
Copy link
Owner

epoupon commented Sep 23, 2024

Ah I may have badly written a test.

Would you mind testing this?
remove the album/scan (not full)/readd the album/scan (not full)
And tell me how it goes?

@awsms
Copy link
Author

awsms commented Sep 23, 2024

After moving the album to somewhere outside of the library folder, rescan, re-move it to the library folder, then rescan : it works!

@epoupon
Copy link
Owner

epoupon commented Sep 23, 2024

Ok, so it works but the migration is not handled :(

@awsms
Copy link
Author

awsms commented Oct 12, 2024

Sorry to bump this, but could you please update the Docker image for lms ? I really want to try out the feature in my prod env 😄

@epoupon
Copy link
Owner

epoupon commented Oct 12, 2024

Hello! Images have been pushed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants