Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced cover art does not show #487

Closed
splintering opened this issue Jun 20, 2024 · 6 comments
Closed

Replaced cover art does not show #487

splintering opened this issue Jun 20, 2024 · 6 comments
Labels
Milestone

Comments

@splintering
Copy link

I replaced the cover art in some flac files that were previously scanned in LMS, then replaced the old files, scanned them again in LMS, and LMS recognized them as updated. The cover art in the web UI did not change though. It seems once the album is in the DB and has a cover, that cover remains as the album cover in the DB, no matter what is in the files.

Is there any way to force a rescan of the cover image without removing the album from the library and re-adding it? And if not, can we get one? :-)

@epoupon
Copy link
Owner

epoupon commented Jun 20, 2024

Cover arts are cached in memory. The cache is supposed to be flushed when a scan is done.
Maybe it is cached on web browser side: what happens if you refresh the UI session?

@splintering
Copy link
Author

I opened a different browser and there was also the old image, it was definitely not cached on the browser side. I reloaded the page a couple of times as well (CTRL-F5), but it did not help, even after a second scan (where I checked "rescan all files").

But maybe I can try to systematically reproduce now that I k ow that it is cached in memory and supposed to be flushed.

@epoupon
Copy link
Owner

epoupon commented Jun 20, 2024

Oh, and does the new cover show up if your restart the service?

@splintering
Copy link
Author

So I tested a little more thorough.

  1. Replaced cover in the files of an existing album and uploaded it.
  2. Reloaded artist page -> no change (as expected)
  3. Scanned
  4. Reloaded artist page -> no change
  5. Tried in different browser that has not been on this page before -> no change
  6. Tried private window in first browser -> no change
  7. Logged off and on again in the UI -> no change
  8. docker stop / start of the LMS service -> new cover is shown

So it seems the memory flush after scanning does not work.

@epoupon
Copy link
Owner

epoupon commented Jun 21, 2024

Ok thanks for testing, will investigate this!

@epoupon
Copy link
Owner

epoupon commented Jun 21, 2024

Confirmed regression of 58df928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants