Fix for Rebar 2.x.y on secondary arches #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erlang + Eunit + Rebar2 behaves differently on secondary arches (mips, sh4, powerpc, and likely other BigEndian ones). Apparently we need to specify setup and teardown procedures explicitly instead of copying meck:new(...) followed by meck:unload() in every test of a suite. Don't know why, but doing this won't hurt. I cannot reproduce this issue with Rebar3. Fixes eproxus#105. Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
lemenkov
force-pushed
the
fix_for_secondary_arches
branch
from
abf6c05
to
ceb6a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erlang + Eunit + Rebar2 behaves differently on secondary arches (mips,
sh4, powerpc, and likely other BigEndian ones). Apparently we need to
specify setup and teardown procedures explicitly instead of copying
meck:new(...) followed by meck:unload() in every test of a suite. Don't
know why, but doing this won't hurt.
I cannot reproduce this issue with Rebar3.
Fixes #105.
Signed-off-by: Peter Lemenkov lemenkov@gmail.com