next.js: Compat with React 19 types #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```bash
$ npx types-react-codemod preset-19 packages --ignore-pattern "**/{node_modules,dist,.turbo}/**"
Processing 1304 files...
Results:
0 errors
1278 unmodified
0 skipped
26 ok
$ npx types-react-codemod preset-19 test --ignore-pattern "**/{node_modules,dist,.turbo}/**"
Processing 1687 files...
Results:
0 errors
1666 unmodified
1 skipped
20 ok
```
The codemod affected 15 files while we only had to change a single file. Confirms that this codemod should really be off by default. Cautionary advise against it should be stronger.
10 tasks
|
Finished. Contributed to eps1lon/DefinitelyTyped#25 and eps1lon/DefinitelyTyped#25 |
eps1lon
changed the title
22 tasks
eps1lon
pushed a commit
that referenced
this pull request
Aug 21, 2024
…etPrefix (vercel#68694) This PR fixes two issues with the use of `assetPrefix`: #1: vercel#64710 `assetPrefix` needs to be handled in `dev`, `deploy`, and `start`. In the current approach, only `dev` and `start` were handled, but a quirk of the implementation caused rewrites for non-asset paths to not be able to be used in `afterFiles` rewrites. vercel#2: When deploying Next.js (such as on Vercel), you need to add your own `beforeFiles` rewrite for `/${assetPrefix}/_next/...` requests or otherwise they would 404. This PR creates an automatically added `rewrite` to `beforeFiles` that handles the case for `dev`, `start`, and `deploy`, removes the existing logic in `filesystem.ts`, and adds more tests to check the behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes eps1lon/DefinitelyTyped#20
Changes
Almost all where codemoddable. I decided against using
react-element-default-any-propssince that would've changed way more usages (15 files) than were necessary (1 file).One
useReducerbreakage that makes it more "vanilla". Good breakage in my book since you don't need to learn aboutReact.Reducernow.One wrong application of
scoped-jsxbecause we add the import globally which is incorrect in an ambient context. The imports should go intodeclare module: eps1lon/types-react-codemod#372Unresolved Issues
styled-jsxstill uses global namespace: Libraries with issues DefinitelyTyped#25