Speedup 06: 30x speedup for _group_detect - handling detections #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calum-chamberlain
approved these changes
Jan 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
matched_filter._group_detect: 30x speedup in handling detectionsprepickto many picks (e.g., 400k) is somewhat slow because ofUTCDateTimeoverhead. ~4x speedup with adding topick.time.nsdirectly.Why was it initiated? Any relevant Issues?
Collecting / handling detections after a
matched_filterrun was getting slow for many detections and templates.This PR contributes to the summary issue in #522
PR Checklist
developbase branch selected?- [ ] Any new features or fixed regressions are be covered via new tests.- [ ] Any new or changed features have are fully documented.CHANGES.md.- [ ] First time contributors have added your name toCONTRIBUTORS.md.