[Crash] Inviting Bot to Raid causes crash at raids.cpp 1505

[neckkola]

I updated to the current master and now bot raiding no longer works for me. Simple use case; spawn a single Bot, invite to raid. Crash on raids.cpp:1505 on the GetPlayerIndex(c) check. @Aeadoin Do you get the same?

[03-19-2023 18:32:12] [Zone] [Crash] C:\GitHubRepo\Server\zone\raids.cpp (1505): Raid::SendGroupLeadershipAA
[03-19-2023 18:32:12] [Zone] [Crash] C:\GitHubRepo\Server\zone\raids.cpp (144): Raid::AddMember
[03-19-2023 18:32:12] [Zone] [Crash] C:\GitHubRepo\Server\zone\bot_raid.cpp (212): Bot::CreateBotRaid
[03-19-2023 18:32:12] [Zone] [Crash] C:\GitHubRepo\Server\zone\bot_raid.cpp (177): Bot::ProcessRaidInvite
[03-19-2023 18:32:12] [Zone] [Crash] C:\GitHubRepo\Server\zone\client_packet.cpp (11815): Client::Handle_OP_RaidCommand
[03-19-2023 18:32:12] [Zone] [Crash] C:\GitHubRepo\Server\zone\client_packet.cpp (508): Client::HandlePacket
[03-19-2023 18:32:12] [Zone] [Crash] C:\GitHubRepo\Server\zone\client_process.cpp (591): Client::Process

[Aeadoin]

I can't seem to reproduce this on master.

[neckkola]

OK, thanks. I will investigate further on my end and let you know. Thank you.

[Aeadoin]

can you try testing on #3125

[neckkola]

Traced it to the db update for bot_id as it failed on 3125 as well.
The manifest has
9225|2023_01_21_bots_raid_members.sql|SHOW COLUMNS FROM raid_members LIKE 'botid'|empty|
though the sql is ALTER TABLE raid_members ADD COLUMN bot_id int(4) NOT NULL DEFAULT 0 AFTER charid;

As I had a botid from the previous versions, it was not running the the script.

It should be changed to check for bot_id instead of botid.

[Kinglykrab]

Should be good once #3132 is merged.

[Kinglykrab]

Merged #3132.