Run swabber as a forking systemd service #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using a forking type systemd service which expects the parent process to fork once and then exit. The Python script was doing two forks which prevented systemd from identifying the forked process. Removing the second fork allows systemd to detect and correctly manage the forked process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is revision of #16 which retains the Python forking/daemon code. It should be compatible with the sysV init script.
I have tested the SystemD service on Debian 9. Starting, stopping and reloading the service should all work correctly. I fixed a bug where an exception would be raised when the service was reload twice. The error was caused by the
banfetcherthread not being restarted after the first reload.The default interface in the example config file is now
+. This interface name is passed to the iptables command line.+is an iptables interface wildcard which will match all interfaces.This PR adds an example service unit file to the repo and includes installation instructions in the README.