silence usage messages when usage was valid and API errors are returned #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silence usage errors to make API errors more apparent. Currently, the API Usage messages can easily hide API errors.
See spf13/cobra#340 (comment) for implementation alternatives. The linked comment is the approach that I found to be most effective.
A few functions were refactored to get usage validation out of the way before silencing usage rendering and executing API commands. Some of these functions had condition branches that could be logically hoisted out of
else
conditions.Before:
and After:
When invalid argument combinations are offered, the usage text is rendered.