⬆️ Updated prod dependencies #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torleifhalseth
approved these changes
May 7, 2024
| @@ -175,6 +175,7 @@ describe('Autocomplete', () => { | |||
| const onChange = jest.fn() | |||
| render( | |||
| <StyledAutocomplete | |||
| optionLabel={(label: string) => label} | |||
There was a problem hiding this comment.
Do we need to add this to the tests?
There was a problem hiding this comment.
after updating styled-components yes, that's what I am saying above. It is probably a bug in sc
mhwaage
pushed a commit
to mhwaage/design-system
that referenced
this pull request
Jul 29, 2024
* ⬆️ ramda, floating-ui * ⬆️ react-aria * rest of datepicker deps * ⬆️ @tanstack/react-virtual * ⬆️@tanstack/react-table * ⬆️ styled-components * ⬇️ try styled-components@6.1.8 * autocomplete: update tests * add comment to test workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3423
there is a bug in styled-components v6.1.9 that is already reported so I installed v6.1.8 instead. It has another issue where the conditional type that got added to Autocomplete (89dd0df) does not work properly if you overwrite Autocomplete styles by doing
const StyledAutocomplete = styled(Autocomplete), thenoptionlabelbecomes required regardless and you have to dooptionLabel={(label: string) => label}. Could be related to this or the multitude of other issues related to typescript & attrs currently so something to keep an eye on