Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Improve story for Divider #744

Merged
merged 3 commits into from
Oct 26, 2020
Merged

🎨 Improve story for Divider #744

merged 3 commits into from
Oct 26, 2020

Conversation

vnys
Copy link
Member

@vnys vnys commented Oct 23, 2020 •
edited
Loading

  • The Divider component now uses a named function instead of an arrow function
  • The component and it’s type is re-exported as *, which gets rid of the error message that type cannot be found

I’ve added some Eslint exceptions to the story, but these issues are something we have to discuss

Part of #735

@vnys vnys self-assigned this Oct 23, 2020
vnys
vnys commented Oct 25, 2020
View reviewed changes
apps/storybook-react/stories/Divider.stories.tsx
@@ -1,3 +1,6 @@
/* eslint-disable @typescript-eslint/no-unsafe-member-access */
/* eslint-disable @typescript-eslint/no-unsafe-call */
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit silly. How do we deal with styled components in the stories? Should we use the same eslint config for the stories that we use in Core React?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote yes 👍

vnys
vnys commented Oct 25, 2020
View reviewed changes
libraries/core-react/src/Divider/index.ts
@@ -1 +1 @@
export { Divider, DividerProps } from './Divider'
export * from './Divider'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By re-exporting * we don’t get error messages about the types not being exported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did kinda the same for Banner

mimarz
mimarz approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

apps/storybook-react/stories/Divider.stories.tsx
@@ -1,3 +1,6 @@
/* eslint-disable @typescript-eslint/no-unsafe-member-access */
/* eslint-disable @typescript-eslint/no-unsafe-call */
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote yes 👍

pomfrida
pomfrida approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@pomfrida pomfrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

wenche
wenche approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@wenche wenche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

libraries/core-react/src/Divider/index.ts
@@ -1 +1 @@
export { Divider, DividerProps } from './Divider'
export * from './Divider'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did kinda the same for Banner

@vnys vnys merged commit 2552da3 into equinor:typescript Oct 26, 2020
@vnys vnys deleted the divider-story branch October 26, 2020 10:16
pomfrida pushed a commit to pomfrida/design-system that referenced this pull request Oct 26, 2020
@vnys @pomfrida
🎨 Improve story for Divider (equinor#744)
ed95a75 
* 🎨 Improve story for Divider

* 🎨 Remove unused imports

* 🎨 Remove blank line
vnys added a commit that referenced this pull request Nov 13, 2020
@vnys
🎨 Improve story for Divider (#744)
5bba248 
* 🎨 Improve story for Divider

* 🎨 Remove unused imports

* 🎨 Remove blank line
vnys added a commit that referenced this pull request Nov 13, 2020
@vnys
🔀 Merge typescript into develop
78d0164 
commit dd8a0cd
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Fri Nov 13 11:33:57 2020 +0100

    Simplify dependencies and package type (#868)

    * Simplify dependencies and package type

    * remove old placeholder file

    * updated to beta.2

commit 5f74c33
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Wed Nov 11 14:50:25 2020 +0100

    re-ordered dependencies (#862)

commit faa9c47
Author: Victor Nystad <vnys@equinor.com>
Date:   Tue Nov 10 21:07:01 2020 +0100

    bump core-react version, update dependencies

commit 783a193
Author: Victor Nystad <vnys@equinor.com>
Date:   Tue Nov 10 20:50:44 2020 +0100

    change license for tokens

commit 617206f
Author: Victor Nystad <vnys@equinor.com>
Date:   Tue Nov 10 20:40:06 2020 +0100

    bump icons version

commit 3a8e6cf
Author: Victor Nystad <vnys@equinor.com>
Date:   Tue Nov 10 20:30:14 2020 +0100

    bump tokens version

commit 48cec04
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Tue Nov 10 12:56:47 2020 +0100

    Moved .map files behind dev flag (#855)

commit 5b53d03
Author: Victor Nystad <vnys@equinor.com>
Date:   Tue Nov 10 12:18:57 2020 +0100

    🔧 Update React imports (#859)

    * 🔧 Change React imports

    Explicitly import `* as React`

    * 🎨 Get React version from Core React package.json

    Since we’re not using the latest version of React at the moment, we
    can’t have Eslint assume we’re using it when linting the code

    * 📝 Update README

    * 📌 Update lock-files

commit ed2582e
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Tue Nov 10 09:24:02 2020 +0100

    🚨 Fix Menu warnings (#856)

    * 🚨 Fixed eslint warnings in Menu story

    * 🐛 Check if onClick is defined in MenuItem

    * 🔥 Removed focus:null to match old story

commit 03c35dd
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Mon Nov 9 14:21:28 2020 +0100

    Rewrite _commons to Typescript (#730)

    * Working with typescript

    * Take two with combined refs

    * ♻️ Rewrite code to avoid ts errors.

    * ♻️ Get rid of ts lint error

    * ♻️ Fix eslint error

    * ♻️ Fix eslint error and warning

    * ♻️ Change elements to fix ts error

    * 🐛 Fix ts error

    * ♻️ More specific type

commit 75c057f
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Mon Nov 9 10:09:17 2020 +0100

    🚨 Fix TS warnings (#847)

    * 🚨 Typography ts warnings fixed

    * 🚨 TabList warnings fixed

    Was an issue with child.props was of type any, had to explicitly type them in the filter/map functions

    * 🚨 Checkbox //ts-nocheck removed to fix ts warning

    * 🚨 Search test linter warnings fixed

    * 🚨 Search linter warnings fixed

    * 🚨 Chip warnings fixed

    * 🚨 Divider warnings fixed

    * ⬆️ pnpm-lock.yaml updated to match package.json

    Due to react-tests failed ERROR  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up-to-date with package.json

    * 🔥 Removed unnecessary type assertion

    Was fixed in tokens instead

commit ffa8ce1
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Mon Nov 9 10:07:46 2020 +0100

    Get the storefront up and running again after Typescript migration (#846)

    * 🚧 Work in progress

    Stuck on styled.css.withConfig is not a function

    * 🚧  Try to get storefront up and running again

    Try to get storefront up and running again -m Strange things are happening with styled.css.withConfig, had to disable the displayName in the config to avoid the error. Should not be necassary

    * ♻️ Swap the props table component with a generel link to storybook

    * ➕ Use EDS from npm instead of local version.

commit 11b8c7b
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Fri Nov 6 12:05:42 2020 +0100

    ♻️  Conform element types (#829)

    * ♻️ Accordion element types conformed

    * ♻️ Avatar element types conformed

    * ♻️ Some renaming of prop types in Banner

    Rename from Props to BannerIconProps etc..

    * ♻️ Breadcrumbs element types conformed

    * ♻️ Card element types conformed

    * ♻️ Rename function to Chip

    Should match with component

    * ♻️ Divider element types conformed

    Also changed Avatar's element type to HTMLDiElement, HTMLHRElement is for hr elements only

    * ♻️ Paper props conformed and exported

    * ♻️ Popover story TS error fix

    Controls popover only by button click

    * 🔥 Removed useless code in Popover story

    The control gets the props automatically

    * ♻️ Popover element types conformed

    * ♻️ Progress indicators element types conformed

    * ♻️ Selection controls element types conformed

    Also refactor arrow functions to named functions as agreed with team

    * ♻️ Slider element types conformed

    * 🔥 Removed useless FunctionComponent

    * ♻️ Renamed prop in Dialog

    from Props to TitleProps

    * ♻️ Table element types conformed

    * 🔥 Removed PropTypes and defaultProps

    Useless after TS migration

    * ♻️ Paper index js to ts

    Got import error in Menu and found this js file...

    * ♻️ Tooltip element types conformed

commit 0df2e85
Author: Victor Nystad <vnys@equinor.com>
Date:   Fri Nov 6 11:47:59 2020 +0100

    ✨ Add demo app (#848)

    * ✨ Add demo app

    * ➖ remove .gitignore since we have that in the root

commit bdcae18
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Thu Nov 5 14:14:01 2020 +0100

    ♻️ Export type for the parent component (#828)

    To export the compound component type was not correct, as using the args in the story revealed

commit 17fe039
Author: Victor Nystad <vnys@equinor.com>
Date:   Thu Nov 5 12:57:16 2020 +0100

    ♻️ Rewrite Dialog stories in Typescript (#752)

    * 🚚 Rename dialog story

    * 🎨 Update component

    * 🎨 Update stories

    * 🎨 Update story and components

    * 🎨 Move OK to the left

    * 🎨 Export props as type

    * 🎨 Export type from Dialog

commit 677093f
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Thu Nov 5 10:28:23 2020 +0100

    Menu typescript story (#815)

    * ♻️ renamed story

    * ♻️ Tweaked component

    * ♻️ Updated story

    * Forced view mode to canvas in story

commit d3c014d
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Wed Nov 4 14:24:49 2020 +0100

    Typescript migration of snackbar stories (#808)

    * 🚚 Rename to tsx

    * ♻️ Use typescript in Snackbar story

    * 📝 Add SnackbarAction as a subcomponent

    * ♻️ Refactor to named function

    * ♻️ Code with typescript error in story. Use FC for  some alignment with components without refs

    * ♻️ Export only the type of the Snackbar itself for the Story

commit b590c03
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Wed Nov 4 13:45:11 2020 +0100

    ♻️  Slider story to Typescript (#806)

    * ♻️ JSX to TSX

    * ♻️ Slider story Typescript

    * 🎨 Added a decorator for margins

    * 🚧 Trying to fix lint errors

    * 🚧 Some lint warnings fixed, a few left

    * 🚚 Rename functions and props

    * 🚧 Still trying to solve ts errors

    Issues with getFormattedText function

    * 🔥 Removed useless fix

    toString() on type any not allowed

    * 🔥 Removed comment

    * 🚨 Finally fixed ts error

    Children was explicitly typed in the subcomponents with number | string

    * 🔥 removed unused

    * ♻️ Fixed import in test

    * 🐛 Fixed a bug where onChange mismatch on HTMLAttributes

    Also changed children type back to ReactNode

    * 🔥 Removed unused type

    Had to replace this type with explicit type because the type was not read elsewhere

    * 🔥 Removed another unused type

    * ♻️ Changed all event types to FormEvent<HTMLDivElement>

    But kept Omit onChange because of the weird error posted in the PR

    * 🐛 onChange expected a function

    Fixes TS event type error

    * 🔥 Removed Omit from type import

    Useless after fix

    * 🔥 Went back to Omit solution for the onChange type mismatch

commit ec0be28
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Wed Nov 4 10:29:43 2020 +0100

    Migrate tabs stories to typescript (#814)

    * 🚚 Rename to tsx extension

    * ♻️ Fix props table and default Tab example

    * ♻️ Add typescript version of states example

    * ♻️ Add width example

    * 🚧 Typescript version of panels example

    * ♻️ Fix issue with onChange event on div

    * ♻️ Typescript version of search story

    * ♻️ Typescript for input in panel story

    * ♻️ Typescript for styled component example

    * ♻️ Add onBlur and onFocus to types and check for their existence

    * ♻️ Remove margins

    * ♻️ Remove onBlur and onFocus from types

    Because we don't change the default method signature anyway

    * ♻️ Remove panel header

    * Fix args. Sneaky

commit 9a5104d
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Tue Nov 3 08:56:11 2020 +0100

    Icon typescript story (#812)

    * ♻️ Renamed story

    * 🚧  updating story

    * 🚧 Working story but typescript error

    * 🐛 Fixed typescript error in story

commit d65f72d
Author: Victor Nystad <vnys@equinor.com>
Date:   Mon Nov 2 09:02:51 2020 +0100

    ♻️ Write table stories in typescript and fix props table (#747)

    * 🚚 Rename table story

    * ♻️ Update story and component

    * ♻️ Rewrite story and component

    * 🎨 Change type of children

    * 🎨 Fix table cell types

    * 🔥 Remove ThHTMLAttributes

    TdHTMLAttributes seem to have the same properties as ThHTMLAttributes,
    so removing the latter.

commit 24a71e8
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Fri Oct 30 16:07:37 2020 +0100

    Table of contents typescript story (#807)

    * ♻️ Renamed story

    * Fixed & simplified story

commit c2b3b1e
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Fri Oct 30 15:50:04 2020 +0100

    ♻️  Tooltip story to Typescript (#804)

    * ♻️ JSX to TSX

    * 🔥 Removed knobs

    * ♻️ Refactor Tooltip story to TSX

    * 📝 Added descriptions to prop table

commit 55c44e4
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Fri Oct 30 15:48:48 2020 +0100

    ♻️  Sidesheet story to Typescript (#803)

    * ♻️ JSX to TSX

    * Fixed merge conflict

    * ♻️ Added controls to story

    * 🔥 Removed useless code (control select is automatic!)

commit f21d3cf
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Fri Oct 30 15:25:07 2020 +0100

    ♻️  Popover story to Typescript (#797)

    * ♻️ JSX to TSX

    * ♻️ Popover default story with controls

    * 🔥 PopoverItem removed from export

    PopoverItem is just for internal use, not needed elsewhere

    * ♻️ Rename function

    * 🔥 Removed comments

    Want to fix these errors instead

    * ♻️ Type React.SyntheticEvent (generic for events) on event handlers

    Cleared lint warnings

    * 🚨 Fixed linter warnings in story

    * ♻️ Open Popover via control AND anchor (story)

    * ♻️ Props name changed in test

    * ♻️ Export merged types

commit 60f3569
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Fri Oct 30 15:24:44 2020 +0100

    Typescript Story: Breadcrumbs (#746)

    * 🚚 JSX to TSX

    * 🚚 Export Props

    * ♻️ Breadcrumbs typed

    * ♻️ Breadcrumb typed

    * ♻️ BreadcrumbsProps updated with HTMLElement instead of JSX

    Mismatch with ref and legacyref if I used JSX... 🤯

    * ♻️ Children should be ReactNode

    * 💡 Children description

    * ♻️ Export merged types

commit 7885ad0
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Fri Oct 30 15:17:20 2020 +0100

    Typescript migration of selection control stories (#798)

    * 🚚 Rename to .tsx extension

    * ♻️ Add new naming pattern for Props. TS for checkbox stories

    * ♻️ Refactor to typescript in radio story

    * ♻️ Rewrite Switch story to typescript

commit 266443a
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Fri Oct 30 14:30:08 2020 +0100

    ♻️  Scrim story to Typescript (#802)

    * ♻️ JSX to TSX

    * ♻️ Export Scrim props

    * ♻️ Simplified Story

    * ♻️ Changed React.HTMLAttributes to HTMLAttributes and it fixed the Proptable

    Yay

commit 2b99731
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Fri Oct 30 14:25:44 2020 +0100

    Fix focus-visible & button focus (#805)

    * Fixed missing tabindex

    * 🐛 fixed focus-visible not being loaded

    * ➖ removed rollup polyfill & updated focus-visible

commit 11d1c3a
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Fri Oct 30 13:52:57 2020 +0100

    Typescript for Chip story (#795)

    * 🚚 Rename to .tsx extension

    * ♻️ Rewrite to typescript. No argsTable is showing

    * 📝 Add stories for chips

commit ae25265
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Fri Oct 30 08:55:13 2020 +0100

    Search typescript story (#799)

    * ♻️ Cleaned up types & lint warnings

    * ♻️ Changed exports

    * ♻️ Changed story file type

    * Updated story

    * ✏️ Fixed wrong name

commit 1feaa6a
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Thu Oct 29 13:04:00 2020 +0100

    ♻️  Pagination Story to Typescript (#796)

    * ♻️ JSX to TSX

    * ♻️ Template literal formatting

    Fixed a TS lint error

    * ♻️ Export props

    * ♻️ Controls added to Pagination story

    * ♻️ Added HTMLAttributes to PaginationProps and removed className + children

    * 🔥 Remove <Body> wrapper in Story

    Not needed anymore due to Docs page

    * 🔥 Removed unused import

    * 🚨 Fixed ts lint errors in all Pagination files

commit 103ac33
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Thu Oct 29 08:46:12 2020 +0100

    Textfield typescript story (#760)

    * ♻️ Renamed story

    * Updated textfield

    * Fixed Textfield

    * Moved props desctructering to function line

commit edccf64
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Wed Oct 28 15:39:30 2020 +0100

    Accordion story typescript (#793)

    * ♻️ Accordion story

    * ♻️ Accordion types

    * 🚚 Moved mdx file to stories-disabled

    * 🔥 Useless argTypes

commit 8af264c
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Wed Oct 28 13:27:04 2020 +0100

    Typescript for Progress stories (#761)

    * 🚚 Rename to tsx extension

    * ♻️ Rewrite Circular progress

    * ♻️ Rewrite dots

    * ♻️ Refactor linear progress

    * ♻️ Rewrite star progress

    * ♻️ Add a hook for reused progress logic

    And so much less code :D

    * 🚚 Use .ts extension

commit b175d4b
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Wed Oct 28 10:07:49 2020 +0100

    Typescript Story: Avatar (#742)

    * 🚚 Renamed to tsx

    * ✨ Declared image type

    Needed for catImg in Avatar story

    * 🚚 Renamed Props to AvatarProps

    ..

    * 📝 Added AvatarProps to story

    * 🚚 Had to move image declarations inside a custom_typings folder

    Was not picked up by TS before

    * ♻️ Arrow function to named function

    * 🎨 Arrow to named

    * 🎨 JPG as type string

    * 🔥 Removed knobs

    Not needed when we have controlled props

    * 🎨 Self closing tags

    * 🚚 Moved custom_typings folder (for jpg module) into stories folder

    Needed for the module to be used in Avatar.stories

    * 🚚 custom_typings moved to core-react/src because of jsconfig is there

    * 🚧 Still working on image module

    * 🚧 Still not able to export the jpg module

    TS reaches module only if custom.d.ts is opened

    * 🎨 Removed useless img module and replaced local src with url

    Quick fix instead of img module to fix ts error on img import

commit 20f0093
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Wed Oct 28 08:32:06 2020 +0100

    Migrate Card story to typescript (#756)

    * 🚚 Change extension to tsx

    * 📝 Adding props table for Card and sub components

    Had to use the JSX.IntrinsicElements trick to make the arg tables show

    * 📝 Add the rest of the Card stories as examples

    * 🚚 Rename function without eds prefic

    * 🔥 Remove knobs completely

    * ➕ Re-add types for storybook, react and react-dom

commit 3f20021
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Tue Oct 27 21:07:42 2020 +0100

    Typescript for list stories (#753)

    * 🚚 Rename to .tsx

    * 📝 Update story with args table, ts and 6.0 storybook api

    * 🐛 Remove displayName

commit 94ebe1b
Author: Victor Nystad <vnys@equinor.com>
Date:   Tue Oct 27 16:13:57 2020 +0100

    🐛 Fix divider story (#759)

    * export *

    * fix story

    * tweak story

commit 050c6f0
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Tue Oct 27 15:28:36 2020 +0100

    Topbar typescript story (#758)

    * ♻️ Changed story type

    * Updates to story & component

commit 66f20dd
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Tue Oct 27 09:53:16 2020 +0100

    default view mode to docs (#751)

commit ab84c2d
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Tue Oct 27 09:33:44 2020 +0100

    Banner story with typescript (#739)

    * 🚚 Rename to .tsx

    * ➕ Add types for styled components and react

    * 📝 Write the story with Typescript

    * ➖ Remove types as it was suddenly a separate PR

    * 🎨 Get rid of types not found warning

    It seems like this way of exporting things will make the warning for types not found in Storybook server go away

    * 🎨 Export all banner props

commit 16a11e5
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Tue Oct 27 07:56:02 2020 +0100

    Typescript for button story (#745)

    * 🚚  Rename to .tsx

    * 🚧  Add a basic story

    * 🚧  Button story with no args table

    * 🎨  Brute force to make args table work

    * 🐛  Remove hardcoded color props

    * 📝  Add the rest of the stories

    * 📝  Use type documentation to show default value

commit 419f5c5
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Mon Oct 26 15:54:19 2020 +0100

    Typography story (#741)

    * Changed story fil ext

    * removed duplicate file

    * ♻️  Updates on naming

    * Figuring out props table

commit 3abd2eb
Author: Victor Nystad <vnys@equinor.com>
Date:   Mon Oct 26 15:09:12 2020 +0100

    🔧 Lint stories (#750)

commit 5bba248
Author: Victor Nystad <vnys@equinor.com>
Date:   Mon Oct 26 11:16:32 2020 +0100

    🎨 Improve story for Divider (#744)

    * 🎨 Improve story for Divider

    * 🎨 Remove unused imports

    * 🎨 Remove blank line

commit c034726
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Fri Oct 23 15:59:26 2020 +0200

    Add types to storybook (#743)

commit 9cb7a2c
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Fri Oct 23 12:51:28 2020 +0200

    fix: Accordion can't handle null value as child #703 (#731)

commit a0d8495
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Fri Oct 23 12:51:17 2020 +0200

    ⬆️ Upgrade storybook from 6.0.16 to 6.0.27 (#736)

    Just to avoid stumbling into fixed bugs

commit ab02609
Author: Nicholas Dalhaug <nicd@equinor.com>
Date:   Fri Oct 23 12:12:16 2020 +0200

    Clean up spacings in CardMedia (#734)

commit 2074823
Author: Victor Nystad <vnys@equinor.com>
Date:   Fri Oct 23 10:27:02 2020 +0200

    Use component src in the Storybook (#723)

    * Tweak divider story and component

    * use publishConfig

    * disable stories

    * rename displayName

    * enable stories

    * remove explisit displayName (where possible)

    * remove test-component

    * remove react-docgen

    * fix rollup config

    * fix Divider and story

    * remove docgen plugin

commit 16bfef6
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Thu Oct 22 19:01:45 2020 +0200

    Children type checking (#729)

    * Improved child checking

    * Fixed & simplified popover children splitting

    * brainfart 🤦🏻‍♂️

    * Fixed menulist using displayName

    * Remove unecessary type

commit af1a6c5
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Thu Oct 22 13:51:33 2020 +0200

    Typescript declarations for eds-icons (#727)

    * tsconfig

    * rollup.config

    * package.json

commit 220f746
Author: Nicholas Dalhaug <nicd@equinor.com>
Date:   Thu Oct 22 13:21:42 2020 +0200

    Banner typescript (#716)

    * Make file types typescript

    * Typescript support for Banner

    * Fix prettier issues

commit f74dd50
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Thu Oct 22 12:51:42 2020 +0200

    Tabs typescript (#715)

    * Renamed to typescript files

    * WIP Tabslist

    * First working component

    * Added fallback and tests for if missing children

commit a228afe
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Thu Oct 22 12:43:34 2020 +0200

    Typescript declarations for eds-tokens (#725)

    * tsconfig

    * rollup.config

    * package.json

    * tsconfig correct dir

    * correct types in package.json

commit a739189
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Thu Oct 22 12:40:40 2020 +0200

    Typescript for popovers (#695)

    * 🚚 Rename to typescript extension

    * 🏷️ Some more types and typescript support

    * 🏷️ Add types for anchor, content and title

    * ♻️ Fix imports for test

    * ♻️ DRY and placement token

    * 🎨 Better readability

    * 🐛 Add clode-icon explicit

    * ♻️ Another approach for popover children

    * Remove empty line

    * Add icon with data attr

    * Make @mimarz happy by extending the component

    * Add support for missing children as React's native functionality

commit b23187a
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Thu Oct 22 08:41:39 2020 +0200

    Slider Typescript (#712)

    * JS to TS

    * Typed SliderInput.tsx

    * Event types

    * Slider types, incomplete

    * Typed MinMax.tsx

    * Tokens typed, incomplete

    * Output.tsx typed

    * Slider Style Props typed complete

    * Slider typed, working on console error about refs

    * Value typed to numbers[] but need a better way to type simple slider

    * String style object instead of number

    * Type "range" typed

    * slidervalue state is always a range

    * valueTwoCommited check in story

    * Border came back after I removed brackets in css

    * Fixed linting error by deconstructing borderProps

    * Removed console

    * Removed unused

    * Slider test typed and fixed type errors

    * Used actual Props in Slider Test

    * Tokens typed

    * Removed unused

    * Fixed another linting error that I missed

    * Added /** to enable description in the prop table

commit 0cb94fa
Author: Håkon <haakon@underbakke.net>
Date:   Wed Oct 21 15:49:41 2020 +0200

    Made AccordionItem toggleable through "isExpanded" (#722)

commit aa602ed
Author: Jørn Ølmheim <jorn@olmheim.com>
Date:   Wed Oct 21 08:07:36 2020 +0200

    Refactor Card to typescript (#699)

    * Update all the files to typescript. Card type is not correct yet.

    * Added wrapper type to the index file and made props nullable.

    * Fixed tests.

commit 073f7e4
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Tue Oct 20 16:00:33 2020 +0200

    Typescript pagination (#704)

    * JS to TS / TSX

    * Pagination to typescript

    * PaginationItem to typescript

    * removed unused

    * types in pagination control

    * Types in function inputs

    * MouseEvent / KeyboardEvent added to onChange function

    * onChange function typed

    * removed console

    * removed unused

    * Added another type in function

    * Correct onClick prev/next buttons

    * removed proptypes

commit 92f139c
Author: Jørn Ølmheim <jorn@olmheim.com>
Date:   Tue Oct 20 15:14:05 2020 +0200

    Refactor Sidesheet to typescript. (#706)

commit 6136281
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Tue Oct 20 14:52:26 2020 +0200

    Typescript for Table of Contents (#714)

    * Convert to typescript

    * Change suffix

commit 7712fd8
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Tue Oct 20 10:28:17 2020 +0200

    Changed .. imports to direct imports (#710)

commit d485245
Author: Frida Erdal <31915755+pomfrida@users.noreply.github.com>
Date:   Tue Oct 20 10:26:48 2020 +0200

    Breadcrumbs Types (#700)

    * changed to tsx

    * Breadcrumb to typescript

    * Breadcrumbs to typescript

    * index to typescript

    * Small typo change

    * Removed blank line

    * Removed another empty linke

    * Another empty line

commit 47ff591
Author: Victor Nystad <vnys@equinor.com>
Date:   Tue Oct 20 09:58:25 2020 +0200

    Convert Dialog to typescript (#683)

    * Change suffix to ts(x)

    * Change suffix to tsx

    * add types for tokens

    * typify Dialog

    * fix stuff

commit 2159b81
Author: Jørn Ølmheim <jorn@olmheim.com>
Date:   Tue Oct 20 09:28:01 2020 +0200

    Fix Chip tests (#705)

    * Typescript conversion of Chips completed and working.

    * Fixed some comments and typings in tests.

    * Fixed Chip tests. No longer allowing imports from index.{js|jsx|ts|tsx} files apparently.

commit 4d6a288
Author: Jørn Ølmheim <jorn@olmheim.com>
Date:   Mon Oct 19 14:48:10 2020 +0200

    Typescript conversion of Chips (#690)

    * Typescript conversion of Chips completed and working.

    * Fixed some comments and typings in tests.

commit c68596d
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Mon Oct 19 14:17:01 2020 +0200

    Fixed jest going crazy and failed test in Accordion (#702)

commit da6d325
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Mon Oct 19 11:26:49 2020 +0200

    Convert component tokens to typescript (#691)

    * Moved json parsing to tokens

    * Converted json to ts files

    * Removed json plugin from tokens

commit 2fd92f7
Author: Victor Nystad <vnys@equinor.com>
Date:   Mon Oct 19 10:59:34 2020 +0200

    Fix linting and tests in typescript branch (#693)

    * comment out stuff

    * trigger build

    * comment in stuff

    * update eslint config

    * nuke testfile

commit 18dbd6f
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Mon Oct 19 07:55:56 2020 +0200

    Accordian typescript (#686)

    * Accordian typescript

    * Types are green!

    * Accordian is no more

    * removed unecessary type

commit b2eebcf
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Mon Oct 19 07:34:11 2020 +0200

    Snackbar types (#687)

    * 🚧 Rename to ts

    * 🏷️ Add types for snackbar

commit a6c3d92
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Fri Oct 16 07:47:02 2020 +0200

    Table typescript take two (#682)

    * convert to typescript

    * Change suffix

    * Radius optional

commit 71d462d
Author: Victor Nystad <vnys@equinor.com>
Date:   Thu Oct 15 14:08:24 2020 +0200

    Bring back the docgen-plugin (#681)

commit f7110fa
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Thu Oct 15 13:53:39 2020 +0200

    correct default (#680)

commit 3df82b1
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Thu Oct 15 13:51:07 2020 +0200

    Typescript Selection Controls (Switch, Checkbox, Radio) (#679)

    * Updated switch to typescript

    * Tweaks to switch typings

    * Radio Typescript

    * Tweaked Radio

    * Checkbox typescript

commit 9ec1cfd
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Thu Oct 15 08:43:31 2020 +0200

    Add types for Tooltip (#671)

    * 🏷️ Add types for Tooltip

    * 🐛 Fix types. Add correct typography token to tooltip

    * 🐛 Add correct tooltip text color

commit e96055b
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Thu Oct 15 08:42:56 2020 +0200

    Button typescript (#675)

    * Converted to typescript!

    * Fixed test failing when using json files

commit f37e773
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Wed Oct 14 08:21:13 2020 +0200

    Typescript Menu (#661)

    * Refactored context

    * Updated MenuItem

    * Simplified mouseevent type

    * MenuList as typescript

    * MenuSection typescript

    * Working typescript Menu

    * Fixed test setup for required props

    * Added missing props comments

    * Renamed displayNames for propstable to work

    * Removed uncessary export

commit 5bffb64
Author: Nicholas Dalhaug <nicd@equinor.com>
Date:   Tue Oct 13 14:00:26 2020 +0200

    Typescript support for Search (#660)

commit a84d525
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Tue Oct 13 07:32:10 2020 +0200

    Update typescript branch with latest changes from develop (#668)

    * 📝  How to run docs (#639)

    * 📝 Start work on how to run docs #635

    * Replace “getting started” with “how to run”

    Moved some of the text from Getting Started to How to run. Also changed
    some of the scripts in the package.yaml file and added some more so we
    don’t have to use `--filter` that much.

    Co-authored-by: Victor Nystad <vnys@equinor.com>

    * 🐛 fix missing props spread on BannerActions (#641)

    * 🐛 fix spacing bugs on CardMedia (#643)

    * 🐛 fix missing props spread on BannerActions

    * 🐛 fix left spacing on card media middle variant

    * 🐛 fix spacing on fullwidth variant of card media

    * Fix pagination bug (#657)

    * Merge documentation into develop (#662)

    * Update whats-new.mdx

    * Update overview.mdx

    * Update whats-new.mdx

    * Update overview.mdx

    * Update overview.mdx

    * Update overview.mdx

    * Add feedback from users

    * Update changelog.mdx

    * Update changelog.mdx

    * Update overview.mdx

    * Update overview.mdx

    * 📝  Add pages for spacings, placement and order and grid alignment (#649)

    * 📝  How to run docs (#639)

    * 📝 Start work on how to run docs #635

    * Replace “getting started” with “how to run”

    Moved some of the text from Getting Started to How to run. Also changed
    some of the scripts in the package.yaml file and added some more so we
    don’t have to use `--filter` that much.

    Co-authored-by: Victor Nystad <vnys@equinor.com>

    * 🐛 fix missing props spread on BannerActions (#641)

    * 🐛 fix spacing bugs on CardMedia (#643)

    * 🐛 fix missing props spread on BannerActions

    * 🐛 fix left spacing on card media middle variant

    * 🐛 fix spacing on fullwidth variant of card media

    * 📝 Add pages for spacings, placement and order and grid alignment

    Co-authored-by: Victor Nystad <vnys@equinor.com>
    Co-authored-by: Sven van Steenis <SvSven@users.noreply.github.com>

    * 📝 Add updated non dark mode Figma images

    We postpone the dark mode images until finished

    Co-authored-by: Bendik Kristiansen <53559062+benkeq@users.noreply.github.com>
    Co-authored-by: Rebecca Brekke <34247620+BeckyBrekke@users.noreply.github.com>
    Co-authored-by: lucasveil <65652493+lucasveil@users.noreply.github.com>
    Co-authored-by: Wenche Tollevsen <wenche.tollevsen@gmail.com>
    Co-authored-by: Sven van Steenis <SvSven@users.noreply.github.com>

    Co-authored-by: Wenche Tollevsen <wenche.tollevsen@gmail.com>
    Co-authored-by: Victor Nystad <vnys@equinor.com>
    Co-authored-by: Sven van Steenis <SvSven@users.noreply.github.com>
    Co-authored-by: Bendik Kristiansen <53559062+benkeq@users.noreply.github.com>
    Co-authored-by: Rebecca Brekke <34247620+BeckyBrekke@users.noreply.github.com>
    Co-authored-by: lucasveil <65652493+lucasveil@users.noreply.github.com>

commit 0b43598
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Mon Oct 12 10:48:27 2020 +0200

    Add types for progress (#659)

    * Add types for star progress

    * Add types for linear progress

    * Add types for dots and fixed some eslint warnings

    * Add types for circular progress

commit c931962
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Mon Oct 12 10:47:53 2020 +0200

    ✨ Types for List (#658)

    * ✨ Types for List #575

    * Add body_short as typography token

    * Some cleanup

commit 19bbed9
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Wed Oct 7 14:33:45 2020 +0200

     Typescript support for scrim (#654)

    * Typescript support for scrim #560

    * Removed duplicate types declaration

commit cdbed7d
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Tue Oct 6 10:08:36 2020 +0200

    Update typescript branch with latest develop changes (#646)

    * 📝  How to run docs (#639)

    * 📝 Start work on how to run docs #635

    * Replace “getting started” with “how to run”

    Moved some of the text from Getting Started to How to run. Also changed
    some of the scripts in the package.yaml file and added some more so we
    don’t have to use `--filter` that much.

    Co-authored-by: Victor Nystad <vnys@equinor.com>

    * 🐛 fix missing props spread on BannerActions (#641)

    * 🐛 fix spacing bugs on CardMedia (#643)

    * 🐛 fix missing props spread on BannerActions

    * 🐛 fix left spacing on card media middle variant

    * 🐛 fix spacing on fullwidth variant of card media

    Co-authored-by: Wenche Tollevsen <wenche.tollevsen@gmail.com>
    Co-authored-by: Victor Nystad <vnys@equinor.com>
    Co-authored-by: Sven van Steenis <SvSven@users.noreply.github.com>

commit 580004c
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Tue Oct 6 10:01:17 2020 +0200

    Typography typescript (#645)

    * Moved base types to tokens library

    * Typography typescript

    * removed comment

    * Uniformed variants type

commit 41aa0cc
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Thu Oct 1 09:37:38 2020 +0200

    Textfield typescript (#638)

    * WIP

    * Updated & working with typescript

    * remove unwatend ts-no-check

    * Fixed misplaced label

    * cleaning code

    * Improved helpertext color for better contrast

commit c9aa99e
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Wed Sep 23 19:32:59 2020 +0200

    Added typescript declarations to core-react (#625)

    * Added missing ts-no-checks

    * Added declarations to lib bundle

commit dad3482
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Wed Sep 23 12:24:56 2020 +0200

    Topbar typescript (#618)

    * Converted to typescript

    * tokens to typescript

    * change props element to match component

    * Aligned var name

    * rewrote template to typescript

commit a80d085
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Wed Sep 23 12:24:37 2020 +0200

    Icon & eds-icons refactor to typescript (#616)

    * Added types to eds-icons

    * Rewrote Icon typescript

    * Fixed data prop checking

    * Added description to .add

    * IconName can also be random string

commit 7677cd4
Author: Michael Marszalek <mmarsz@equinor.com>
Date:   Tue Sep 22 16:44:36 2020 +0200

    Typescript config tweaks (#623)

    * Fixed tsc checking libs

    * Removed docgen-typescript as it was casuing errors

commit 16762fd
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Mon Aug 31 18:15:18 2020 +0200

    Revert "[WIP]: Types for scrim" (#530)

commit d00e7b4
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Mon Aug 31 18:03:11 2020 +0200

    Try to add types for Scrim. This is crazy :/

commit 531b841
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Mon Aug 31 07:05:56 2020 +0200

    Typescript support for avatar (#524)

commit c690c7b
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Fri Aug 28 10:10:46 2020 +0200

    Fix test (#523)

    * First try for typescript support for Divider

    * In the middle of using proptables from ts components in the storybook

    * Lot's of lot's of tweeks to make prop tables in storybook working. This commit is kind of a proof of concept

    * Remove classname, key and ref from props table

    * Removed debug env

    * Removed configuration of typescript in storybook main

    * Remove old testing stuffs

    * Remove old rollup typescript plugin

    * Delete copy'n pasted babel typescript transpiler, we use rollup plugin instead

    * Remove testing stuffs

    * Fix test

commit b709eb8
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Fri Aug 28 09:59:26 2020 +0200

    Typescript support for Divider (#520)

    * First try for typescript support for Divider

    * In the middle of using proptables from ts components in the storybook

    * Lot's of lot's of tweeks to make prop tables in storybook working. This commit is kind of a proof of concept

    * Remove classname, key and ref from props table

    * Removed debug env

    * Removed configuration of typescript in storybook main

    * Remove old testing stuffs

    * Remove old rollup typescript plugin

    * Delete copy'n pasted babel typescript transpiler, we use rollup plugin instead

    * Remove testing stuffs

commit 1bd85f7
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Wed Aug 26 10:13:46 2020 +0200

    Typescript setup for core-react (#515)

    * Add typescript packages

    * Add tsconfig

    * Couldn't do it without the tslib deps, even if it's supposed to be a dep on rollup-plugin-typescript2

    * Disable ts checks as a baseline before porting

commit 6c3d18f
Author: Victor Nystad <vnys@equinor.com>
Date:   Mon Aug 31 12:52:32 2020 +0200

    Typescript eslint (#527)

    * configure eslint for typescript

    * one config to rule them all

    * update stuff

commit 5941ca5
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Mon Aug 31 07:05:56 2020 +0200

    Typescript support for avatar (#524)

commit eed0b57
Author: Victor Nystad <vnys@equinor.com>
Date:   Fri Aug 28 10:47:21 2020 +0200

    update jest config (#525)

commit 8720e16
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Fri Aug 28 10:10:46 2020 +0200

    Fix test (#523)

    * First try for typescript support for Divider

    * In the middle of using proptables from ts components in the storybook

    * Lot's of lot's of tweeks to make prop tables in storybook working. This commit is kind of a proof of concept

    * Remove classname, key and ref from props table

    * Removed debug env

    * Removed configuration of typescript in storybook main

    * Remove old testing stuffs

    * Remove old rollup typescript plugin

    * Delete copy'n pasted babel typescript transpiler, we use rollup plugin instead

    * Remove testing stuffs

    * Fix test

commit df360ba
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Fri Aug 28 09:59:26 2020 +0200

    Typescript support for Divider (#520)

    * First try for typescript support for Divider

    * In the middle of using proptables from ts components in the storybook

    * Lot's of lot's of tweeks to make prop tables in storybook working. This commit is kind of a proof of concept

    * Remove classname, key and ref from props table

    * Removed debug env

    * Removed configuration of typescript in storybook main

    * Remove old testing stuffs

    * Remove old rollup typescript plugin

    * Delete copy'n pasted babel typescript transpiler, we use rollup plugin instead

    * Remove testing stuffs

commit d7a2815
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Wed Aug 26 10:13:46 2020 +0200

    Typescript setup for core-react (#515)

    * Add typescript packages

    * Add tsconfig

    * Couldn't do it without the tslib deps, even if it's supposed to be a dep on rollup-plugin-typescript2

    * Disable ts checks as a baseline before porting

commit f9f566f
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Tue Aug 25 13:34:28 2020 +0200

    Typescript support in icons package (#514)

    * Fix tsconfig for tokens package. Didn't realise that this was missing...

    * Add typescript and typescript config

    * Rename index.js -> index.ts

    * Rename file endings for icons in figma broker

commit ca8b367
Author: Wenche Tollevsen <wenche.tollevsen@gmail.com>
Date:   Tue Aug 25 11:45:39 2020 +0200

    Types for tokens library (#507)

    * Install typescript and types for react and react-dom

    * Add support for typescript by using .ts extensions for js files

    * Change file extensions to .ts in figma-broker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomfrida pomfrida pomfrida approved these changes

@wenche wenche wenche approved these changes

@mimarz mimarz mimarz approved these changes

Assignees

@vnys vnys

Labels
storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vnys @mimarz @wenche @pomfrida