Add parameter endpoints for REST and graphQL #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frode-aarstad
force-pushed
the
parameters_api
branch
from
58b34a6
to
e235ccf
Compare
frode-aarstad
force-pushed
the
parameters_api
branch
4 times, most recently
from
99808e5
to
8a47b80
Compare
oysteoh
reviewed
Sep 9, 2021
oysteoh
reviewed
Sep 9, 2021
oysteoh
reviewed
Sep 9, 2021
oysteoh
reviewed
Sep 9, 2021
oysteoh
reviewed
Sep 10, 2021
frode-aarstad
force-pushed
the
parameters_api
branch
2 times, most recently
from
16fd445
to
16150ea
Compare
oysteoh
suggested changes
Sep 10, 2021
frode-aarstad
force-pushed
the
parameters_api
branch
from
16150ea
to
cf7223d
Compare
oysteoh
reviewed
Sep 10, 2021
|
|
||
|
|
||
| def test_get_ensemble_parameters(poly_example_tmp_dir, dark_storage_client): | ||
| ensemble_id = uuid.uuid4() |
There was a problem hiding this comment.
sorry, did not discover this when i looked at the code earlier.. but would it make more sense doing something like
resp: Response = dark_storage_client.get("/experiments")
experiment_json = resp.json()
ensemble_id = experiment_json[0]["ensemble_ids"][0]
to get the ensemble id to ask for instead of generating an id? And with that it should be possible to avoid the changes in lines 56-61 in enkf.py - get_name()?
There was a problem hiding this comment.
The best way of solving the changes in enkf.py is probably to update the ids during initialization/startup. This way calling GET /experiments/some random uuis/parameters would not crash
There was a problem hiding this comment.
guess this is a perfect issue to discuss on tuesday on our small technical planning - how to initialize and generate the id's... ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves equinor/ert-storage#151