Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sphinx <7.2 #5892

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Pin sphinx <7.2 #5892

merged 1 commit into from
Aug 17, 2023

Conversation

sondreso
Copy link
Collaborator

@sondreso sondreso commented Aug 17, 2023

Issue
An excpetion occours when using sphinx version 7.2.0. Possible incompatability with Furo theme.

Created issue #5893

Approach
Pin and create issue to unpin

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Updated documentation
  • Ensured new behaviour is tested

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

An excpetion occours when using sphinx version 7.2.0. Possible
incompatability with foru theme.
@sondreso sondreso added the release-notes:skip If there should be no mention of this in release notes label Aug 17, 2023
@sondreso sondreso self-assigned this Aug 17, 2023
@sondreso sondreso marked this pull request as ready for review August 17, 2023 07:06
@codecov-commenter
Copy link

Codecov Report

Merging #5892 (8f4df30) into main (a07afe4) will increase coverage by 0.11%.
Report is 21 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5892      +/-   ##
==========================================
+ Coverage   81.77%   81.89%   +0.11%     
==========================================
  Files         347      347              
  Lines       21616    21613       -3     
  Branches      737      737              
==========================================
+ Hits        17677    17699      +22     
+ Misses       3686     3661      -25     
  Partials      253      253              

see 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@valentin-krasontovitsch valentin-krasontovitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you!

@eivindjahren eivindjahren merged commit f8b5fdc into equinor:main Aug 17, 2023
40 checks passed
@sondreso sondreso deleted the pin-sphinx branch August 17, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants