Fix the realization number for the stdout and stderr files

[larsevj]

Issue
Resolves #6486

Pre review checklist

• Read through the code changes carefully after finishing work
• Make sure tests pass locally (after every commit!)
• Prepare changes in small commits for more convenient review (optional)
• PR title captures the intent of the changes, and is fitting for release notes.
• Updated documentation
• Ensured that unit tests are added for all new behavior (See
  Ground Rules),
  and changes to existing code have good test coverage.

Pre merge checklist

• Added appropriate release note label
• Commit history is consistent and clean, in line with the contribution guidelines.

[larsevj]

Did a small refactoring in _job_data to avoid setting real = node.parent multiple times. Not strictly necessary in order to resolve the issue.

[andreas-el]

Did a small refactoring in _job_data to avoid setting real = node.parent multiple times. Not strictly necessary in order to resolve the issue.

But nice, since it was probably wrong to begin with to set that variable twice.

What did concern me a bit though, was if all nodes actually had a parent. If that isn't the case, we now enforce the system to stop. I've tried to see if this is the case, but could not find any situation where that happened.

Ref.

def _job_data(self, index: QModelIndex, node: Node, role: int):
         assert node.parent
         real = node.parent

[andreas-el]

Nice! Seems to do the trick. Good work! 🚀

[larsevj]

Did a small refactoring in _job_data to avoid setting real = node.parent multiple times. Not strictly necessary in order to resolve the issue.

But nice, since it was probably wrong to begin with to set that variable twice.

What did concern me a bit though, was if all nodes actually had a parent. If that isn't the case, we now enforce the system to stop. I've tried to see if this is the case, but could not find any situation where that happened.

Ref.

def _job_data(self, index: QModelIndex, node: Node, role: int):
         assert node.parent
         real = node.parent

Yes that assert part is probably a leftover from before, and it might be best to just remove it? I believe that _job_data will only be called on job - nodes, which should all have a realization node as parent?

[codecov-commenter]

Codecov Report

Merging #6501 (cacd8f4) into main (fcf4d19) will increase coverage by 0.00%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #6501   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files         342      341    -1     
  Lines       20716    20715    -1     
  Branches      938      938           
=======================================
  Hits        17294    17294           
  Misses       3131     3131           
+ Partials      291      290    -1     

Files	Coverage Δ
src/ert/gui/model/snapshot.py	89.63% <100.00%> (-0.04%)	⬇️
src/ert/gui/simulation/run_dialog.py	91.32% <ø> (ø)

... and 13 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!