Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin sphinx #6555

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Unpin sphinx #6555

merged 1 commit into from
Nov 13, 2023

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Nov 13, 2023

Issue
Resolves #5893

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@codecov-commenter
Copy link

Codecov Report

Merging #6555 (4f9a4b6) into main (1fbcf37) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6555   +/-   ##
=======================================
  Coverage   83.52%   83.52%           
=======================================
  Files         346      346           
  Lines       20786    20786           
  Branches      948      948           
=======================================
  Hits        17362    17362           
  Misses       3130     3130           
  Partials      294      294           

see 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@larsevj larsevj added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Nov 13, 2023
@larsevj
Copy link
Contributor Author

larsevj commented Nov 13, 2023

Have successfully built the docs locally and during the GitHub tests which was the place where the error originally occured.

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@larsevj larsevj merged commit da6ef5b into equinor:main Nov 13, 2023
44 checks passed
@larsevj larsevj deleted the test_for_unpin_sphinx branch November 13, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin sphinx
3 participants