Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor local_ensemble mask calculations #7197

Closed

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Feb 16, 2024

While working on #7046 , some refactoring was found to be beneficial. Separating this out here.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

A normal interpretation of "all" involves vacuous truth,
which is not the case in these local_storage functions.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5344f25) 84.71% compared to head (fcadc88) 85.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7197      +/-   ##
==========================================
+ Coverage   84.71%   85.43%   +0.72%     
==========================================
  Files         380      380              
  Lines       22633    22626       -7     
  Branches      931      932       +1     
==========================================
+ Hits        19174    19331     +157     
+ Misses       3340     3178     -162     
+ Partials      119      117       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren added the release-notes:skip If there should be no mention of this in release notes label Feb 16, 2024
@eivindjahren eivindjahren self-assigned this Feb 16, 2024
@eivindjahren eivindjahren changed the title Refactor storage tests Refactor local_ensemble mask calculations Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants