Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move workflow_runner and add top-level exports for semeio & everest #8254

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jun 27, 2024

Used for equinor/everest#44 and equinor/semeio#626

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eivindjahren eivindjahren changed the title Add top-level exports for everest & semeio Move workflow_runner and add top-level exports for semeio & everest Jun 28, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.31250% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.85%. Comparing base (2ce2080) to head (7ca6dc2).

Files Patch % Lines
src/ert/ensemble_evaluator/_ensemble.py 88.88% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8254      +/-   ##
==========================================
- Coverage   86.86%   86.85%   -0.01%     
==========================================
  Files         378      378              
  Lines       23946    23948       +2     
  Branches      631      623       -8     
==========================================
+ Hits        20800    20801       +1     
+ Misses       3067     3066       -1     
- Partials       79       81       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren merged commit ae913f7 into equinor:main Jun 28, 2024
37 of 38 checks passed
@eivindjahren eivindjahren deleted the export_for_everest branch June 28, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants