Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_number_of_existing_runpaths() #8297

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #8276

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad self-assigned this Jul 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.92%. Comparing base (6be9385) to head (d710c60).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8297      +/-   ##
==========================================
- Coverage   86.92%   86.92%   -0.01%     
==========================================
  Files         375      375              
  Lines       23523    23524       +1     
  Branches      624      626       +2     
==========================================
  Hits        20448    20448              
+ Misses       2999     2997       -2     
- Partials       76       79       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dafeda
Copy link
Contributor

dafeda commented Jul 29, 2024

image

I'm now getting: 100 out of 100 realizations are running in existing runpaths.
This look alright I think.
However, the Experiment name input is "red" indicating a duplicate experiment name, which I don't think makes sense since we are re-running in an existing experiment.
Another issue perhaps?

@frode-aarstad
Copy link
Contributor Author

frode-aarstad commented Aug 5, 2024

Experiment name input is "red" indicating a duplicate experiment name, which I don't think makes sense since we are re-running in an existing experiment. Another issue perhaps?

This is another issue. I will create one

@frode-aarstad frode-aarstad merged commit ac458b7 into equinor:main Aug 6, 2024
37 checks passed
@frode-aarstad frode-aarstad deleted the fix-real-number-count branch August 6, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculation of existing run path shows too many realizations
3 participants