Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering for History vectors in plotter #8677

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Sep 10, 2024

Screenshot 2024-09-10 at 15 17 42
Screenshot 2024-09-10 at 15 17 37

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el added the release-notes:improvement Automatically categorise as improvement in release notes label Sep 10, 2024
@andreas-el andreas-el self-assigned this Sep 10, 2024
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution adding it to the filter!

@andreas-el andreas-el force-pushed the add_checkbox_history_plot_selector branch from f196727 to d7c3f4d Compare September 11, 2024 06:56
@andreas-el andreas-el force-pushed the add_checkbox_history_plot_selector branch from 4a82a8c to ed26022 Compare September 11, 2024 12:02
@andreas-el andreas-el force-pushed the add_checkbox_history_plot_selector branch from ed26022 to 09a4236 Compare September 11, 2024 12:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (add_checkbox_history_plot_selector@69eada0). Learn more about missing BASE report.

Additional details and impacted files
@@                          Coverage Diff                          @@
##             add_checkbox_history_plot_selector    #8677   +/-   ##
=====================================================================
  Coverage                                      ?   90.86%           
=====================================================================
  Files                                         ?      339           
  Lines                                         ?    21020           
  Branches                                      ?        0           
=====================================================================
  Hits                                          ?    19100           
  Misses                                        ?     1920           
  Partials                                      ?        0           
Flag Coverage Δ
gui-tests 76.33% <100.00%> (?)
integration-tests 53.42% <12.50%> (?)
unit-tests 68.43% <37.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andreas-el andreas-el merged commit 8368b14 into equinor:add_checkbox_history_plot_selector Sep 11, 2024
35 checks passed
@andreas-el andreas-el deleted the add_checkbox_history_plot_selector branch September 11, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants