Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace simulation thread with simulation task in BatchContext #8681

Closed

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Sep 11, 2024

Issue
Continuation of #8466

Creating scheduler message queues (via asyncio.Queue) is done in different asyncio loop (and thread too), which might cause an issue when running in python3.8. This replaces the sim thread with sim task in order to make sure that we run on the same loop.

Approach

Replace & simplify.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq self-assigned this Sep 11, 2024
@jonathan-eq jonathan-eq force-pushed the fix-batch-simulator-bug branch 2 times, most recently from af63521 to 1d93953 Compare September 11, 2024 11:56
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.89%. Comparing base (22e95fc) to head (dd263fe).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/simulator/batch_simulator_context.py 91.66% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8681   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files         342      342           
  Lines       21213    21207    -6     
=======================================
- Hits        19281    19276    -5     
+ Misses       1932     1931    -1     
Flag Coverage Δ
gui-tests 76.10% <13.88%> (-0.04%) ⬇️
integration-tests 53.37% <13.88%> (-0.04%) ⬇️
unit-tests 68.64% <91.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathan-eq
Copy link
Contributor Author

Closing this as it requires more changes in everest. See additional comments in #8466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants