WIP: enkf_uti_util: added util_alloc_stdin_line. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakim-hove
approved these changes
Feb 8, 2018
|
Please don't merge PRs that are WIPs. A PR should be unWIPed before review starts. |
pgdr
reviewed
Feb 8, 2018
| input = (char*)util_realloc(input , input_size ); | ||
| } | ||
| } else end = true; | ||
| } while (!end); |
There was a problem hiding this comment.
this could just be while (true) { ... } with a break, and then we could get rid of end.
|
OK - I agree with both:
and
However - this code has been moved as close to extinction as possible in the ert codebase; it worked before (it was just moved from libecl in equinor/resdata#321) and is good enough for a limited future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
util_alloc_stdin_line was supposed to die, but is still used in the ert-rep.
Approach
util_alloc_stdin_lin is moved to enkf_uti_util.
Pre un-WIP checklist
Depends on