Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BRINE support #410

Closed
wants to merge 3 commits into from
Closed

Add BRINE support #410

wants to merge 3 commits into from

Conversation

wouterjdb
Copy link
Contributor

@wouterjdb wouterjdb commented May 26, 2021 •
edited
Loading

This PR adds support for BRINE in FlowNet.

Contributor checklist

  • 🎉 This PR closes Support for BRINE #381.
  • 📜 I have broken down my PR into the following tasks:
    • Complete tasks in issue
    • Fix BRINE keyword in DATA deck (not yet working as expected)
    • Add PVTWSALT
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@wouterjdb wouterjdb added the enhancement New feature or request label May 26, 2021
@wouterjdb wouterjdb added this to the BRINE support in FlowNet milestone May 26, 2021
@wouterjdb wouterjdb self-assigned this May 26, 2021
@wouterjdb wouterjdb removed their assignment Jun 17, 2021
@plgbrts plgbrts mentioned this pull request Jun 18, 2021
Merged
3 tasks
@olelod olelod closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olelod olelod Awaiting requested review from olelod olelod will be requested when the pull request is marked ready for review olelod is a code owner

@fahaddilib fahaddilib Awaiting requested review from fahaddilib fahaddilib will be requested when the pull request is marked ready for review fahaddilib is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
BRINE support in FlowNet
Development

Successfully merging this pull request may close these issues.

Support for BRINE
2 participants
@wouterjdb @olelod