-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assumed syntax in parameters.txt is not aligned with semeio #96
Comments
I don't immediately understand the reasoning behind what semeio does, but is it a different use case? E.g. should outgoing metadata also just include parameters unique after stripping everything before colon (except exceptions i.e. The primary use case for these parameters in the metadata right now is for clients such as Webviz to be able to offer filtering based on them. E.g. "show me all data from iteration X where parameter Y has value Z". |
Semeio has taken a deliberate decision to ignore prefixes (before colon) when executing DESIGN_KW. If fmu-dataio then starts to add meaning to that otherwise ignored prefix, we need to be careful. The reason for semeios decision is to let users switch between design matrix parameters (DESIGN_KW) and history matching parameter (GEN_KW, which always adds a prefix). |
Context: equinor/semeio#59 and equinor/semeio#163 |
Thanks. fmu-dataio is not aware of the contents, it merely parses and puts into outgoing metadata for a data object. So the actual question then is probably how this should look like in the metadata. E.g when user switches between GEN_KW and DESIGN_KW. |
Problem is perhaps mitigated in #102 |
Reference implementation for
parameters.txt
-parsing is inhttps://github.com/equinor/semeio/blob/master/semeio/jobs/design_kw/design_kw.py
This is not in line with:
fmu-dataio/src/fmu/dataio/_utils.py
Line 220 in c3111c9
which interprets a nested dictionary structure from the keys based on colons in the key string.
Semeio actively ignores prefixes before colons in keys.
The text was updated successfully, but these errors were encountered: