Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumed syntax in parameters.txt is not aligned with semeio #96

Closed
berland opened this issue Sep 17, 2021 · 5 comments
Closed

Assumed syntax in parameters.txt is not aligned with semeio #96

berland opened this issue Sep 17, 2021 · 5 comments

Comments

@berland
Copy link
Collaborator

berland commented Sep 17, 2021

Reference implementation for parameters.txt-parsing is in
https://github.com/equinor/semeio/blob/master/semeio/jobs/design_kw/design_kw.py

This is not in line with:

GLOBVAR:VOLON_FLOODPLAIN_VOLFRAC 0.256355

which interprets a nested dictionary structure from the keys based on colons in the key string.

Semeio actively ignores prefixes before colons in keys.

@perolavsvendsen
Copy link
Member

I don't immediately understand the reasoning behind what semeio does, but is it a different use case? E.g. should outgoing metadata also just include parameters unique after stripping everything before colon (except exceptions i.e. LOG10_)?

The primary use case for these parameters in the metadata right now is for clients such as Webviz to be able to offer filtering based on them. E.g. "show me all data from iteration X where parameter Y has value Z".

@berland
Copy link
Collaborator Author

berland commented Sep 20, 2021

Semeio has taken a deliberate decision to ignore prefixes (before colon) when executing DESIGN_KW. If fmu-dataio then starts to add meaning to that otherwise ignored prefix, we need to be careful.

The reason for semeios decision is to let users switch between design matrix parameters (DESIGN_KW) and history matching parameter (GEN_KW, which always adds a prefix).

@berland
Copy link
Collaborator Author

berland commented Sep 20, 2021

Context: equinor/semeio#59 and equinor/semeio#163

@perolavsvendsen
Copy link
Member

Thanks. fmu-dataio is not aware of the contents, it merely parses and puts into outgoing metadata for a data object. So the actual question then is probably how this should look like in the metadata. E.g when user switches between GEN_KW and DESIGN_KW.

@berland
Copy link
Collaborator Author

berland commented Sep 28, 2021

Problem is perhaps mitigated in #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants