Use semeio for parameter parsing, make nesting explicit #102
Conversation
berland
force-pushed
the
semeio-paramparsing
branch
3 times, most recently
from
d8e99db
to
a8036aa
Compare
The nesting of parameters dictionary is specific to fmu-dataio. Make it more explicit by putting it in a different function
berland
force-pushed
the
semeio-paramparsing
branch
from
a8036aa
to
03486e3
Compare
|
|
||
| ptext = "tests/data/drogon/ertrun1/realization-0/iter-0/parameters_justified.txt" | ||
|
|
||
| res = _utils.read_parameters_txt(ptext) | ||
| res = _utils.nested_parameters_dict(_utils.read_parameters_txt(ptext)) | ||
|
|
||
| assert res["SENSNAME"] == "rms_seed" | ||
| assert res["GLOBVAR"]["VOLON_PERMH_CHANNEL"] == 1100 |
There was a problem hiding this comment.
Further up the form is now res["GLOBVAR:VOLON_PERMH_CHANNEL"]. Put here is res["GLOBVAR"]["VOLON_PERMH_CHANNEL"]?
There was a problem hiding this comment.
Yes, that is what the nested_parameters_dict() function does, splitting by colons.
|
This PR maybe changes some behaviour of dict ordering, as the previous code used |
There may actually be no need for OrderedDict() when >= python 3.6. cf. https://softwaremaniacs.org/blog/2020/02/05/dicts-ordered/ |
Regardless, I cannot see that dict ordering should be important to preserve, other than for readability. |
The nesting of parameters dictionary is specific to fmu-dataio. Make it more explicit
by putting it in a different function