Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ert_shared to ert.shared and include ERT as requirement #237

Merged
merged 12 commits into from
Aug 19, 2022

Conversation

perolavsvendsen
Copy link
Member

No description provided.

Co-authored-by: Sondre Sortland <sondreso@users.noreply.github.com>
@perolavsvendsen
Copy link
Member Author

Ref offline discussions: Have tested this by explicitly installing ert 2.38.0b5 then fmu-dataio from this branch, and I am able to open ERT.

Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nitpick suggestion

src/fmu/dataio/hook_implementations/jobs.py Outdated Show resolved Hide resolved
src/fmu/dataio/hook_implementations/jobs.py Outdated Show resolved Hide resolved
perolavsvendsen and others added 5 commits August 17, 2022 13:52
Co-authored-by: Sondre Sortland <sondreso@users.noreply.github.com>
Co-authored-by: Sondre Sortland <sondreso@users.noreply.github.com>
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM, and tested locally as well 🙂

@perolavsvendsen perolavsvendsen merged commit a41e333 into equinor:main Aug 19, 2022
@perolavsvendsen perolavsvendsen deleted the ert_shared_change branch August 19, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants