Run from runpath root #93

jcrivenaes · 2021-09-17T12:44:37Z

No description provided.

perolavsvendsen · 2021-09-17T13:01:05Z

tests/test_fmu_dataio_cube.py

+    # assert meta["data"]["bbox"]["xmin"] == 0.0
+    # assert meta["data"]["bbox"]["xmax"] == 550.0
+
+    # logger.info("\n%s", json.dumps(meta, indent=2))


Supposed to be commented out or forgotten?

perolavsvendsen

I struggle to understand it, tbh. I'm inclined to give it a go and test it together with the parallel smry2arrow initiative - which is currently the only use case requiring fmu-dataio to run from RUNPATH. I think we can afford that at this point.

jcrivenaes added 8 commits September 17, 2021 07:42

Fix: running from RUNPATH root shall work

18355b5

Add dryrun option for developer testing

ce050b5

Use runfolder key instead of _pwd attribute

ae77849

Add tests on folderlist and runs from RUNPATH

17cd024

Add black, pylint and flake8

f0e9bac

fixup! Adjust code

2544911

Refactor lookup of folders and inlude RUNPATH

1376fbc

fixup! flake8

6f092ef

jcrivenaes requested a review from perolavsvendsen September 17, 2021 12:51

perolavsvendsen reviewed Sep 17, 2021

View reviewed changes

perolavsvendsen approved these changes Sep 20, 2021

View reviewed changes

perolavsvendsen mentioned this pull request Sep 20, 2021

Able to run through ERT forward jobs #89

Closed

jcrivenaes merged commit 251fa12 into equinor:main Sep 22, 2021

jcrivenaes deleted the run-from-runpath-root branch April 21, 2022 05:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run from runpath root #93

Run from runpath root #93

jcrivenaes commented Sep 17, 2021

perolavsvendsen Sep 17, 2021

perolavsvendsen left a comment

Run from runpath root #93

Run from runpath root #93

Conversation

jcrivenaes commented Sep 17, 2021

perolavsvendsen Sep 17, 2021

Choose a reason for hiding this comment

perolavsvendsen left a comment

Choose a reason for hiding this comment