This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
WIP: Job dispatch cleanup #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakim-hove
reviewed
Oct 24, 2017
| #@staticmethod | ||
| #def fsInfo(path = None): | ||
| # if path is None: | ||
| # path = os.getcwd() |
There was a problem hiding this comment.
No - do not comment out code; delete properly!
joakim-hove
approved these changes
Oct 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
The job_dispatch.py (and job_manager.py class) script in libres has quite some crappy debug code from a time back when we were investigating cluster issues intensively. We should remove these no-longer required attributes:
Everything related to JobManager.fsinfo( ) is to be removed.
Approach
JobManager.fsinfo( ), reference to this function and consequences of the reference has been removed.
Pre un-WIP checklist