Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some cases where display methods failed #923

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

asmfstatoil
Copy link
Collaborator

refact: removed some warnings

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (4c9be0b) 33.62% compared to head (f0cf077) 33.61%.

Files Patch % Lines
.../java/neqsim/fluidMechanics/flowNode/FlowNode.java 0.00% 10 Missing ⚠️
...idBoundary/heatMassTransferCalc/FluidBoundary.java 0.00% 6 Missing ⚠️
...va/neqsim/standards/gasQuality/Draft_GERG2004.java 0.00% 6 Missing ⚠️
.../neqsim/standards/gasQuality/Standard_ISO6976.java 0.00% 6 Missing ⚠️
src/main/java/neqsim/standards/Standard.java 0.00% 5 Missing ⚠️
...c/main/java/neqsim/thermo/system/SystemThermo.java 0.00% 2 Missing ⚠️
...chemicalReactions/chemicalEquilibriaum/ChemEq.java 0.00% 1 Missing ⚠️
...sSimulation/mechanicalDesign/MechanicalDesign.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #923      +/-   ##
============================================
- Coverage     33.62%   33.61%   -0.01%     
- Complexity     5127     5128       +1     
============================================
  Files           701      701              
  Lines         69818    69844      +26     
  Branches       7991     7996       +5     
============================================
+ Hits          23476    23479       +3     
- Misses        44866    44890      +24     
+ Partials       1476     1475       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@asmfstatoil asmfstatoil merged commit 5133ef1 into master Feb 22, 2024
7 checks passed
@asmfstatoil asmfstatoil deleted the fix_null_error_display branch February 22, 2024 13:05
@asmfstatoil asmfstatoil restored the fix_null_error_display branch February 22, 2024 13:05
@asmfstatoil asmfstatoil deleted the fix_null_error_display branch February 22, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants