Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use macos-latest in github workflow tests #620

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Use macos-latest in github workflow tests #620

merged 3 commits into from
Aug 12, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Jun 10, 2024

Resolves #616

@larsevj larsevj force-pushed the use_macos_latest branch 4 times, most recently from f86a8d0 to c7366c9 Compare July 25, 2024 09:57
@larsevj
Copy link
Contributor Author

larsevj commented Aug 12, 2024 •
edited
Loading

tests/forward_models/overburden_timeshift/test_ots_integration.py fails on macos arm on the following:

    _err = 0.01
    nx = s_horizon.get_nx()
    ny = s_horizon.get_ny()
    arr = to_numpy(s_horizon)
    sh_top_left = arr[: ny // 2 - 1, : nx // 2 - 1].sum()
    sh_bottom_right = arr[ny // 2 :, nx // 2 :].sum()
    assert ((sh_top_left - _err) > 0) == results[0]

you get the following results for sh_top_left for all test cases:

Linux              |  macos arm
2015702.6024329471  |  2012214.0447139177
12344796.313041849  |  12347656.972199338
1340392.4831519802  |  1337984.4934645826
0.008223739636816994  |  0.01285521929680931

@larsevj
Use macos-latest in the github tests
3f5deab 
- Disables the test test_ots_config_run_parameters for macos
  due to different numbers produced in scipy interpolate on
  macos arm
xjules
xjules approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's skip it 😄 🚀

@larsevj larsevj merged commit e41f4d2 into main Aug 12, 2024
10 checks passed
@larsevj larsevj deleted the use_macos_latest branch August 12, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjules xjules xjules approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python3.12 tests fail with macos-14 arm but not macos-12
2 participants
@larsevj @xjules