Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runeclipse: Support multiple license servers #718

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented Jul 24, 2024

Close #714

@mferrera
Copy link
Collaborator

I'd suggest removing the ert bottom pin in pyproject.toml for this PR and we can re-add it in a follow-up PR, after making a new release. I guess there is value in having subscript run against ert pre-release versions in the nightly ci here.

Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me. I have not tested it. 👍

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.73%. Comparing base (814c869) to head (f5adaf1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files          50       50           
  Lines        6696     6696           
=======================================
  Hits         5741     5741           
  Misses        955      955           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alifbe alifbe merged commit 122eae4 into equinor:main Jul 25, 2024
6 checks passed
@alifbe alifbe deleted the runeclipse-license branch July 25, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need support for multiple license servers + local license servers on some sites
3 participants