Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mypy for type annotation linting #187

Closed
anders-kiaer opened this issue Jan 30, 2020 · 0 comments · Fixed by #195
Closed

Use mypy for type annotation linting #187

anders-kiaer opened this issue Jan 30, 2020 · 0 comments · Fixed by #195
Assignees
@asnyv
Labels
enhancement 🚀 New feature or request good first issue Good for newcomers maintenance question Further information is requested

Comments

@anders-kiaer
Copy link
Collaborator

anders-kiaer commented Jan 30, 2020 •
edited
Loading

This would improve the code base, make it more readable for newcomers, and also help find undiscovered bugs.

Suggested way forward:

  • pip install mypy (or better, added to test dependencies)
  • cd webviz_config
  • mypy --package webviz_config --ignore-missing-imports --disallow-untyped-defs
  • Fix errors/warnings by type hinting the functions.
  • Commit to github 🍺💃
@anders-kiaer anders-kiaer added enhancement 🚀 New feature or request good first issue Good for newcomers question Further information is requested maintenance labels Jan 30, 2020
@asnyv asnyv mentioned this issue Feb 6, 2020
Merged
@asnyv asnyv closed this as completed in #195 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asnyv asnyv

Labels
enhancement 🚀 New feature or request good first issue Good for newcomers maintenance question Further information is requested
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added type hinting asnyv/webviz-config
2 participants
@anders-kiaer @asnyv