fix: Grid3DLayer should apply flag "ZIncreasingDownwards" for correct readout of depth. #1723 #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers for relevant layers. equinor#1724
nilscb
added
bug
nilscb
changed the title
nilscb
changed the title
w1nklr
changed the title
…rrect readout of depth. equinor#1723"
w1nklr
requested changes
Oct 23, 2023
typescript/packages/subsurface-viewer/src/layers/grid3d/grid3dLayer.ts
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/shader_modules/utilities.ts
Outdated
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/grid3d/grid3dLayer.stories.tsx
Show resolved
Hide resolved
typescript/packages/subsurface-viewer/src/layers/grid3d/grid3dLayer.ts
Outdated
Show resolved
Hide resolved
nilscb
changed the title
nilscb
changed the title
w1nklr
approved these changes
Oct 23, 2023
hkfb
pushed a commit
that referenced
this pull request
Oct 23, 2023
## [0.4.2](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.4.1...subsurface-viewer@0.4.2) (2023-10-23) ### Bug Fixes * Grid3DLayer should apply flag "ZIncreasingDownwards" for correct readout of depth. ([#1729](#1729)) ([108b660](108b660)), closes [#1723](#1723) [#1724](#1724)
|
🎉 This issue has been resolved in version subsurface-viewer@0.4.2 🎉 The release is available on GitHub release |
w1nklr
added a commit
to w1nklr/webviz-subsurface-components
that referenced
this pull request
Oct 24, 2023
Introduced by PR equinor#1729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ers for relevant layers. #1724