Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CO2Leakage - Visualize CO2 mass plus various other improvements #1252

Merged
merged 59 commits into from
Mar 7, 2024
Merged

CO2Leakage - Visualize CO2 mass plus various other improvements #1252

merged 59 commits into from
Mar 7, 2024

Conversation

AudunSektnanNR
Copy link
Contributor

@AudunSektnanNR AudunSektnanNR commented Dec 19, 2023 •
edited
Loading

Main improvements:

  • Visualization of CO2 mass (total mass, aqueous or gas)
  • Add region support for the containment plots
  • Option to only plot containment for a specified zone (requires containment script to be run with zone information)
  • Option to plot containment split into zones
  • Visualization threshold for the map view (requires mass maps to have 0s instead of masked values)

Some graphical improvements:

  • Current zoom level in the map no longer resets when changing settings
  • Consistent formatting of numbers in the containment plots
  • Various minor visual changes

Other changes:

  • Standardized filenames to match containment script output files
  • Allow relative paths to well and polygon files (relative to ensemble root)
  • Removal of simple volume

This is directly related to equinor/webviz-subsurface-testdata#146

Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Task 1
    • Task 2
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

AudunSektnanNR and others added 30 commits October 31, 2023 11:39
@AudunSektnanNR
CO2Leakage: Minor visual fix in Property-tab.
89072bf
@AudunSektnanNR
Black last commit.
7b90a76
@AudunSektnanNR
CO2Leakage: First iteration, adding code for co2 mass maps.
1ea1564
@AudunSektnanNR
CO2Leakage: Add some checks for existing files.
2aa3d89
CO2Leakage: Minor fix for mass maps.
291dcb0
@AudunSektnanNR
CO2Leakage: Plot unit for time migration and mass maps.
be71432
@FredrikNevjenNR
Removal of simple volume
8508502
@FredrikNevjenNR
Match ccs script naming (actual volume). Add space b4 well.
595ccbc
@FredrikNevjenNR
Change input from ccs-scripts to plume_x
7496fbc
@FredrikNevjenNR
Fix minor bug in space before well name hack
cc3eafe
@AudunSektnanNR
Merge pull request #2 from FredrikNevjenNR/master
e257d53 
Remove simple volume. Match ccs script naming.
@FredrikNevjenNR
Fix zoom level when updating plot
494dd44
@FredrikNevjenNR
Fix formatting of numbers and plot ranges
fee7c84
@FredrikNevjenNR
Fix zoom bug that messed up scales
cd379e4
@FredrikNevjenNR
Merge pull request #1 from AudunSektnanNR/develop
b045671 
Updating my fork
@FredrikNevjenNR
Add visualization of dissolved and free CO2
163791a
@FredrikNevjenNR
Add visualization threshold
bb6dd91
@FredrikNevjenNR
Show total mass in realization
3ce1f96
@FredrikNevjenNR
Small fix for zoom in containment plots
fd04709
@AudunSektnanNR
Merge pull request #3 from FredrikNevjenNR/master
9bb3afd 
Fix zoom reset and minor formatting in containment plots
@FredrikNevjenNR
Add zone selection for containment plot.
5a4204d
@FredrikNevjenNR
Add zone functionality
d460c07
@FredrikNevjenNR
Allow relative well and boundary paths
186a0fc
@FredrikNevjenNR
Use scientific notation for total mass
c57282e
@FredrikNevjenNR
Clean up code for relative path to well and boundaries
21b6080
@FredrikNevjenNR
Small fixes
328c99f
@FredrikNevjenNR
Fix handling of input files
aba0931
@FredrikNevjenNR
Add feedback button
1807fad
@FredrikNevjenNR
Clean up zone functionality
dee1a8d
@FredrikNevjenNR
Disable feedback button (for now)
18c7ef5
@AudunSektnanNR AudunSektnanNR mentioned this pull request Dec 22, 2023
Merged
@AudunSektnanNR AudunSektnanNR changed the title CO2Leakage - Plot co2 mass plus various other improvements CO2Leakage - Plot CO2 mass plus various other improvements Dec 22, 2023
@AudunSektnanNR AudunSektnanNR changed the title CO2Leakage - Plot CO2 mass plus various other improvements CO2Leakage - Visualize CO2 mass plus various other improvements Dec 22, 2023
@AudunSektnanNR AudunSektnanNR marked this pull request as ready for review December 22, 2023 13:46
FredrikNevjenNR and others added 18 commits January 15, 2024 13:36
@FredrikNevjenNR
Minor fix to map update handling
ab23f99
@FredrikNevjenNR
Add region support for the containment plots
fb9ffed
@FredrikNevjenNR
Formatting
f857a63
@AudunSektnanNR
CCS-88: Change default behavior of UNSMRY-file, print warning if larg…
66fe416 
…e file (#8)

* CCS-88: Change default behavior of UNSMRY-file, only load and plot if specified.

* CCS-88: Print warning if some CSV-files are large.

* CCS-88: Minor fix.
@FredrikNevjenNR
Merge branch 'branch_fn' into develop_for_testing
224d3e6
@FredrikNevjenNR
Merge pull request #9 from AudunSektnanNR/develop_for_testing
40b3826 
Develop for testing
@FredrikNevjenNR
Make visualization updates more intuitive.
1a0bb32
@FredrikNevjenNR
Minor fix
e88ff76
@FredrikNevjenNR
Merge pull request #10 from AudunSektnanNR/branch_fn
27c7b4b 
Minor fixes to visualization update
@FredrikNevjenNR
Add support for separate well pick and polygon files for each ensembl…
6bf440d 
…e (requires same relative path).
@FredrikNevjenNR
Minor formatting in formation-well warning.
9fe02e8
@FredrikNevjenNR
Merge pull request #12 from AudunSektnanNR/branch_fn_the_fifth
1681454 
Add support for separate well pick and polygon files for each ensembl…
@AudunSektnanNR
Merge pull request #13 from AudunSektnanNR/develop_for_testing
17da3bd 
Latest from develop for testing
@AudunSektnanNR
Merge branch 'master' into develop
a88d92b
@AudunSektnanNR
pylint
a433063
@AudunSektnanNR
mypy
1346015
@AudunSektnanNR
Update changelog.
1bc378d
@HansKallekleiv
Merge branch 'master' into develop
242c18a
@HansKallekleiv HansKallekleiv merged commit f3bbc33 into equinor:master Mar 7, 2024
4 checks passed
@AudunSektnanNR AudunSektnanNR deleted the develop branch March 8, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansKallekleiv HansKallekleiv HansKallekleiv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AudunSektnanNR @HansKallekleiv @FredrikNevjenNR