Drag drop #3
Merged
Drag drop #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
er-contreras
commented
Jul 22, 2021
er-contreras
commented
- Add 2 new JavaScript files and import them as modules:
- one will contain methods related to drag / drop and sorting functionality.
- the other will contain methods related to the status updates (completed: true / false).
- Add event listeners to list items (dragstart, dragover, drop) and to checkbox (change).
- Update items object's values for index and completed keys upon user actions.
- Store the updated array of items in local storage, so the user gets the correct list values after the page reloads.
henatan99
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Hi @eri8-9 ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| dropZone.setAttribute('draggable', 'true'); | ||
| inputlabel.setAttribute('for', `inputCheck-${i}`); | ||
| inputCheck.setAttribute('type', 'checkbox'); | ||
| if (window.localStorage.length == null || window.localStorage.length === 0) { |
There was a problem hiding this comment.
- Very smart to check if the local storage is cleared before rendering the list elements, 👍 . But you should mention it in your readme or PR summary as it may not be noticed easily by others and it can be mistakenly related to some other issues that the lists are not rendering. Anyways, you did a great job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.