Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const qualifiers to copy constructors #303

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

seva-deriv
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.925% when pulling 70f1f4e on seva-deriv:copy_ctor into 49b27fe on eranpeer:master.

@seva-deriv
Copy link
Contributor Author

seva-deriv commented Dec 7, 2022

I've got a wierd compilation error (on Clang 14.0.1 Ubuntu 22.04, looks like a bug in compiler):

fakeit.hpp:9142:20: error: no matching constructor for initialization of 'MethodProgress<boost::asio::awaitable<void>, *****>'
            return progress;
                   ^~~~~~~~
fakeit.hpp:9114:13: note: candidate constructor not viable: expects an lvalue for 1st argument
            MethodProgress(MethodProgress &other) :
            ^

This change fixed that and it also seems to be more generic and widely used.

I may also propose just to remove ctors that look like defaulted.

@FranckRJ
Copy link
Collaborator

FranckRJ commented Dec 7, 2022

Thanks, it should fix #302. And just to be sure, it happens only when compiling in C++23, no ?

@FranckRJ FranckRJ added this to the 2.4.0 milestone Dec 7, 2022
@seva-deriv
Copy link
Contributor Author

Not sure if only in C++23 but indeed it happened when compiled in C++23

@FranckRJ FranckRJ changed the base branch from master to dev-2.4.0 December 8, 2022 09:07
@FranckRJ FranckRJ merged commit d2b5f1e into eranpeer:dev-2.4.0 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants