Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: manual test case&plan-case-relations paging use sql join #2910

Merged
merged 5 commits into from
Nov 10, 2021

Conversation

sfwn
Copy link
Member

@sfwn sfwn commented Nov 7, 2021

What type of this PR

/kind refactor

What this PR does / why we need it:

fix slow sql:

  • refactor: manual test case&plan-case-relations paging use sql join

Tested in dev and feels good :P

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @Effet

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.4 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@sfwn sfwn added dop devops plaoform refactor labels Nov 7, 2021
@erda-bot erda-bot requested a review from Effet November 7, 2021 15:30
@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #2910 (50b0468) into master (cec84c3) will decrease coverage by 0.09%.
The diff coverage is 93.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2910      +/-   ##
==========================================
- Coverage   17.56%   17.47%   -0.10%     
==========================================
  Files        1325     1325              
  Lines      135161   135824     +663     
==========================================
- Hits        23747    23739       -8     
- Misses     108960   109629     +669     
- Partials     2454     2456       +2     
Impacted Files Coverage Δ
apistructs/testplan.go 44.44% <ø> (ø)
modules/dop/endpoints/testplan.go 3.50% <0.00%> (-0.02%) ⬇️
modules/dop/services/testplan/testplan.go 37.65% <95.23%> (+13.36%) ⬆️
modules/cmp/steve_request.go 0.00% <0.00%> (-0.49%) ⬇️
.../components/cmp-dashboard-nodes/memTable/render.go 13.17% <0.00%> (-0.08%) ⬇️
modules/cmp/cluster_resource.go 0.00% <0.00%> (ø)
modules/cmp/steve/aggregator.go 0.00% <0.00%> (ø)
modules/cmp/steve/predefined_resource.go
modules/cmp/steve/request.go 0.47% <0.00%> (ø)
.../components/cmp-dashboard-nodes/cpuTable/render.go 14.11% <0.00%> (+0.58%) ⬆️
... and 3 more

@sfwn sfwn force-pushed the refactor/mt-case-paging branch 9 times, most recently from fc14e9e to 3b2ef19 Compare November 9, 2021 09:08
@sfwn sfwn changed the title refacotr: manual test case&plan-case-relations paging use sql join refactor: manual test case&plan-case-relations paging use sql join Nov 9, 2021
@Effet Effet merged commit ddb13bd into erda-project:master Nov 10, 2021
@Effet
Copy link
Member

Effet commented Nov 10, 2021

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Nov 10, 2021
…rda-project#2910)

* refacotr: manual test case&plan-case-relations paging use sql join

* limit testset's directory length

* fix: manual-test fix paging by updatedAt

* migration: manual test add migration for slow sql

* add unit test for mt-case-paging refactor
erda-bot added a commit that referenced this pull request Nov 10, 2021
…2910) (#2985)

* refacotr: manual test case&plan-case-relations paging use sql join

* limit testset's directory length

* fix: manual-test fix paging by updatedAt

* migration: manual test add migration for slow sql

* add unit test for mt-case-paging refactor

Co-authored-by: sfwn <sfwnlin@gmail.com>
snakorse pushed a commit to snakorse/erda that referenced this pull request Nov 10, 2021
…rda-project#2910)

* refacotr: manual test case&plan-case-relations paging use sql join

* limit testset's directory length

* fix: manual-test fix paging by updatedAt

* migration: manual test add migration for slow sql

* add unit test for mt-case-paging refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dop devops plaoform refactor
Development

Successfully merging this pull request may close these issues.

2 participants