Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scale): support scale the resource not restart pod #645

Merged
merged 1 commit into from
Jun 22, 2021
Merged

feat(scale): support scale the resource not restart pod #645

merged 1 commit into from
Jun 22, 2021

Conversation

Muzry
Copy link
Contributor

@Muzry Muzry commented Jun 22, 2021

What type of this PR

Add one of the following kinds:
/kind bug

What this PR does / why we need it:

  • feat(scale): support scale the resource not restart pod

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @your-reviewer

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@codecov
Copy link

codecov bot commented Jun 22, 2021 •
edited
Loading

Codecov Report

Merging #645 (9ce8029) into master (a36a0a6) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 9ce8029 differs from pull request most recent head effd846. Consider uploading reports for the commit effd846 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   10.65%   10.65%           
=======================================
  Files         863      863           
  Lines       81726    81726           
=======================================
  Hits         8709     8709           
  Misses      72098    72098           
  Partials      919      919
Impacted Files Coverage Δ
...dules/scheduler/executor/plugins/k8s/deployment.go 0.00% <0.00%> (ø)

luobily
luobily reviewed Jun 22, 2021
View reviewed changes
modules/scheduler/impl/servicegroup/scale.go
@@ -33,6 +33,9 @@ func (s *ServiceGroupImpl) Scale(sg *apistructs.ServiceGroup) (apistructs.Servic
if len(sg.Services) != 1 {
return apistructs.ServiceGroup{}, fmt.Errorf("services count more than 1")
}
if oldSg.ProjectNamespace != "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add annotation

luobily
luobily approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@luobily luobily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@luobily luobily merged commit 01756b9 into erda-project:master Jun 22, 2021
@Muzry
Copy link
Contributor Author

Muzry commented Jun 22, 2021

/cherry-pick release/1.0

@erda-bot
Copy link
Member

Automated cherry pick failed, please resolve the confilcts and create PR manually.
Details:

Auto-merging modules/scheduler/executor/plugins/k8s/deployment.go
[auto-cherry-pick-pr/645 f3d33b8c] feat(scale): support scale the resource not restart pod (#645)
 Author: Muzry <muzrry@gmail.com>
 Date: Tue Jun 22 16:16:23 2021 +0800
 2 files changed, 10 insertions(+), 2 deletions(-)

@Muzry Muzry mentioned this pull request Jun 22, 2021
Merged
luobily pushed a commit that referenced this pull request Jun 22, 2021
@Muzry
feat(scale): support scale the resource not restart pod (#645) (#649)
303b3e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luobily luobily luobily approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Muzry @erda-bot @luobily