Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline merge branch allow wildcard #959

Merged

Conversation

JdaieLin
Copy link
Contributor

@JdaieLin JdaieLin commented Jul 14, 2021

What type of this PR

Add one of the following kinds:
feature

What this PR does / why we need it:

pipeline merge branch allow wildcard

e.g.

on:
   merge:
       branches: 
           - feature/*

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

sfwn
sfwn previously approved these changes Jul 14, 2021
@sfwn
Copy link
Member

sfwn commented Jul 14, 2021

Commit must be signed.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #959 (aea462f) into master (d28928c) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
- Coverage   11.27%   11.27%   -0.01%     
==========================================
  Files         953      953              
  Lines       99296    99276      -20     
==========================================
- Hits        11197    11193       -4     
+ Misses      87094    87076      -18     
- Partials     1005     1007       +2     
Impacted Files Coverage Δ
modules/dop/endpoints/pipeline.go 1.47% <0.00%> (+<0.01%) ⬆️
pkg/mock/mock.go 26.13% <0.00%> (-3.41%) ⬇️
modules/pipeline/spec/pipeline.go 7.01% <0.00%> (-0.81%) ⬇️
modules/pkg/innerdomain/innerdomain.go 0.00% <0.00%> (ø)
modules/msp/resource/deploy/handlers/handler.go 0.00% <0.00%> (ø)
...es/dicehub/service/publish_item/item_statistics.go 0.00% <0.00%> (ø)

Copy link
Contributor Author

@JdaieLin JdaieLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@JdaieLin JdaieLin requested a review from sfwn July 14, 2021 07:05
pipeline merge branch allow wildcard

lint
@JdaieLin JdaieLin force-pushed the feature/pipeline-merge-branch-match branch from fae2cd0 to aea462f Compare July 14, 2021 07:30
@sfwn sfwn merged commit 87ca801 into erda-project:master Jul 14, 2021
@sfwn
Copy link
Member

sfwn commented Jul 14, 2021

/cherry-pick release/1.1

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Jul 14, 2021
pipeline merge branch allow wildcard

lint

Co-authored-by: Lin Hongrui <hongrui.lhr@alibaba-inc.com>
sfwn pushed a commit that referenced this pull request Jul 15, 2021
pipeline merge branch allow wildcard

lint

Co-authored-by: Lin Hongrui <hongrui.lhr@alibaba-inc.com>
@sfwn
Copy link
Member

sfwn commented Jul 15, 2021

linked issue: #949

@Muzry Muzry mentioned this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants