-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: proteus-doc -> proteus #1041
Conversation
* Update wave_tools.rst * Update wave_tools.rst * Update wave_tools.rst * Update wave_tools.rst * Update wave_tools.rst * Update wave_tools.rst * Update spatial_tools.rst
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
+ Coverage 48.89% 48.9% +<.01%
==========================================
Files 514 514
Lines 100018 100021 +3
==========================================
+ Hits 48907 48911 +4
+ Misses 51111 51110 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you fix the class hierarchy graphs? https://erdc.github.io/proteus-doc/api/proteus.LinearSolvers.html versus https://proteustoolkit.org/api/proteus.LinearSolvers.html
Also, on the Python API doc's, we might want to put the submodules before the sub-packages, or at least limit the depth of the subpackage table of contents so the subpackage section is brief. https://erdc.github.io/proteus-doc/api/proteus.html
* Add templates for sphinx autodoc [WIP] * Makefile point to _templates/apidoc for sphinx templates * APIDOC: ignore *.so files, toctree depth to 1, clean capi * DOC: doc -> docs (standard for readthedocs)
@cekees this is ready to be reviewed/merged (not squashed and merged so that people keep authorship of the documentation they modified). |
@cekees as a side note, clicking on "Python API" leads you to this page: https://tridelat.github.io/proteus/api/modules.html, where you need to click on "proteus package" to actually access the API doc. This can be bypassed to access the proteus doc directly, although having it this way is "safer" if one day an extra package is installed side-by-side with proteus, as it would appear on that intermediate page. |
a700be1
to
a44c676
Compare
Found a few more issues: 1) the readthedocs template is not scaling the inheritance graphs properly, 2) the C++ docs are not showing ineritance graphs at all, and 3) the C++ docs aren't including the mathematical formulas that have been formatted for doxygen. |
@cekees for 1) I will need to dig a little bit, |
@cekees for 3) the mathematical formulas actually seem to render, for example here: https://tridelat.github.io/proteus/capi/classDensityRelation.html#exhale-class-classdensityrelation |
* DOC: correct warnings/errors * DOC: disable breathe and exhale * DOC: ./build directory, doxygen first, remove exhale * DOC: add link in toc to doxygen doc and sphinx doc * DOC: update copyright
This PR brings the changes to documentation from proteus-doc to proteus, keeping commit authorship (but could not keep the date/time of changes due to some conflicts).
The reason for bringing back the documentation here is that it seems easier to have an automatic way to build it if it is centralised on this repo, see #1040
This should not be squashed and merged (regular merge)