refactor basemap service and rename to wmts_imagery #100

sdc50 · 2018-08-17T14:45:03Z

fix bug with resulting bounding box
add ability to clip image to bounding box

fix bug with resulting bounding box add ability to clip image to bounding box

stickler-ci · 2018-08-17T14:45:14Z

quest_provider_plugins/wmts_imagery.py

+        x = int(m * 2 ** (zoom_level - 1) * (lon / 180 + 1))
+        y = int(m / (2 * math.pi) * 2 ** zoom_level *
+                (math.pi - math.log(math.tan(math.pi / 4 + math.radians(lat) / 2))))
+


W293 blank line contains whitespace

stickler-ci · 2018-08-17T14:45:14Z

quest_provider_plugins/wmts_imagery.py

+                (math.pi - math.log(math.tan(math.pi / 4 + math.radians(lat) / 2))))
+
+        return x, y
+


W293 blank line contains whitespace

stickler-ci · 2018-08-17T14:45:14Z

quest_provider_plugins/wmts_imagery.py

+        return xmin_pixel, ymin_pixel, xmax_pixel, ymax_pixel
+
+
+    @staticmethod


E303 too many blank lines (2)

stickler-ci · 2018-08-17T14:45:15Z

quest_provider_plugins/wmts_imagery.py

+        p = param.ParamOverrides(self, kwargs)
+        bbox = listify(p.bbox)
+
+        tile_indices = self._get_indices_from_bbox(*bbox, p.zoom_level)


E999 SyntaxError: only named arguments may follow *expression

stickler-ci · 2018-08-17T14:47:48Z

quest_provider_plugins/wmts_imagery.py

+        """
+        image_array = np.moveaxis(array, -1, 0)  # move the bands from the last axis to the first.
+        count, height, width = image_array.shape
+        transform = rasterio.transform.from_bounds(*bbox, width, height)


E999 SyntaxError: only named arguments may follow *expression

stickler-ci · 2018-08-17T16:11:40Z

test/data.py

+                  'NAM 181 AFWA Grid - Central America/Caribbean (12-km Resolution)'],
+                 ['NAM 182 AFWA Grid - North Pacific  (12-km Resolution)',
+                  'NAM 182 AFWA Grid - North Pacific  (12-km Resolution)'],
+                 ['NAM 190 Grid - CONUS (Staggered B-grid on rotated lat/lon grid using the 60 NAM hybrid levels(NAM 12km Domain))',


E501 line too long (132 > 120 characters)

stickler-ci · 2018-08-17T16:11:40Z

test/data.py

+                 ['NAM 182 AFWA Grid - North Pacific  (12-km Resolution)',
+                  'NAM 182 AFWA Grid - North Pacific  (12-km Resolution)'],
+                 ['NAM 190 Grid - CONUS (Staggered B-grid on rotated lat/lon grid using the 60 NAM hybrid levels(NAM 12km Domain))',
+                  'NAM 190 Grid - CONUS (Staggered B-grid on rotated lat/lon grid using the 60 NAM hybrid levels(NAM 12km Domain))'],


E501 line too long (133 > 120 characters)

stickler-ci · 2018-08-17T16:11:40Z

test/data.py

+                  'NAM 215 AWIPS Grid - CONUS (20-km Resolution)'],
+                 ['NAM 216 AWIPS Grid - Regional - Alaska (45-km Resolution)',
+                  'NAM 216 AWIPS Grid - Regional - Alaska (45-km Resolution)'],
+                 ['NAM 218 AWIPS Grid - CONUS (12-km Resolution; full complement of pressure level fields and some surface-based fields)',


E501 line too long (138 > 120 characters)

stickler-ci · 2018-08-17T16:11:41Z

test/data.py

+                 ['NAM 216 AWIPS Grid - Regional - Alaska (45-km Resolution)',
+                  'NAM 216 AWIPS Grid - Regional - Alaska (45-km Resolution)'],
+                 ['NAM 218 AWIPS Grid - CONUS (12-km Resolution; full complement of pressure level fields and some surface-based fields)',
+                  'NAM 218 AWIPS Grid - CONUS (12-km Resolution; full complement of pressure level fields and some surface-based fields)'],


E501 line too long (139 > 120 characters)

stickler-ci · 2018-08-17T16:11:41Z

test/data.py

+                  'NAM 221 AWIPS Grid - High Resolution North American Master Grid (32-km Resolution)'],
+                 ['NAM 221 AWIPS Grid - N. American Master (32-km Resolution) (GOES Simulated Brightness Temp.)',
+                  'NAM 221 AWIPS Grid - N. American Master (32-km Resolution) (GOES Simulated Brightness Temp.)'],
+                 ['NAM 242 AWIPS Grid - Over Alaska (11.25 KM Resolution; full complement of pressure level fields and some surface-based fields)',


E501 line too long (147 > 120 characters)

stickler-ci · 2018-08-17T16:11:41Z

test/data.py

+                 ['NAM 221 AWIPS Grid - N. American Master (32-km Resolution) (GOES Simulated Brightness Temp.)',
+                  'NAM 221 AWIPS Grid - N. American Master (32-km Resolution) (GOES Simulated Brightness Temp.)'],
+                 ['NAM 242 AWIPS Grid - Over Alaska (11.25 KM Resolution; full complement of pressure level fields and some surface-based fields)',
+                  'NAM 242 AWIPS Grid - Over Alaska (11.25 KM Resolution; full complement of pressure level fields and some surface-based fields)'],


E501 line too long (148 > 120 characters)

stickler-ci · 2018-08-17T16:11:41Z

test/data.py

+              'default':
+                  'https://server.arcgisonline.com/ArcGIS/rest/services/World_Imagery/MapServer/tile/{Z}/{Y}/{X}',
+              'range': [
+                   ['http://c.tile.openstreetmap.org/{Z}/{X}/{Y}.png',


E126 continuation line over-indented for hanging indent

stickler-ci · 2018-08-17T16:17:56Z

test/data.py

+              'default': 'https://server.arcgisonline.com/ArcGIS/rest/services/World_Imagery/MapServer/tile/'
+                         '{Z}/{Y}/{X}',
+              'range': [
+                   ['http://c.tile.openstreetmap.org/{Z}/{X}/{Y}.png',


E126 continuation line over-indented for hanging indent

coveralls · 2018-08-17T16:28:05Z

Pull Request Test Coverage Report for Build 347

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 69.529%

Totals
Change from base Build 333:	0.3%
Covered Lines:	7425
Relevant Lines:	10679

💛 - Coveralls

AaronV77 · 2018-08-17T18:01:58Z

@sdc50 why are all the notebooks have output being deleted when this was already done in the Quest Updates PR?

sdc50 · 2018-08-17T23:09:51Z

Hold off on this. I renamed the NoteBooks directory to notebooks, but it looks like git didn't pick up the new directory.

AaronV77 · 2018-08-20T13:29:33Z

@sdc50 The only way that I've had success with name changes is from within PyCharm.

dharhas · 2018-08-20T13:32:51Z

Did you use 'git mv' typically you have to do the rename in a isolated commit. If I remember right, I've had issues in the past when mixing renaming and edits to the same file in a single commit.

AaronV77 · 2018-08-20T14:00:28Z

I wonder how the ipynb checkpoints got committed when it is in our gitignore file.. Also you still have the WMTS example notebook deleted in this PR.

sdc50 · 2018-08-20T14:02:08Z

@dharhas thanks. git mv worked.
@AaronV77 I've got the notebooks added back in, so this PR should be ready to go.

AaronV77 · 2018-08-20T14:04:45Z

It still says that the WMTS notebook has been deleted.

sdc50 · 2018-08-20T14:08:21Z

@AaronV77 make sure to clean up the commit messages when you squash and merge.

refactor basemap service and rename to wmts_imagery

e28022f

fix bug with resulting bounding box add ability to clip image to bounding box

stickler-ci reviewed Aug 17, 2018

View reviewed changes

stickler

02506b5

stickler-ci reviewed Aug 17, 2018

View reviewed changes

sdc50 added 3 commits August 17, 2018 09:50

stickler

8635240

change name of notebooks

5f2ac86

update download options in test data

26b57c3

stickler-ci reviewed Aug 17, 2018

View reviewed changes

stickler

e894dec

stickler-ci reviewed Aug 17, 2018

View reviewed changes

stickler

ad21880

sdc50 and others added 3 commits August 20, 2018 08:51

cleanup notebook checkpoints

b3078bd

Delete .DS_Store

502d3b9

rename NoteBooks dir to notebooks

c7cfa98

AaronV77 approved these changes Aug 20, 2018

View reviewed changes

AaronV77 merged commit 35ae02b into erdc:master Aug 20, 2018

sdc50 deleted the bugfix/wmts_service branch August 20, 2018 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor basemap service and rename to wmts_imagery #100

refactor basemap service and rename to wmts_imagery #100

sdc50 commented Aug 17, 2018

stickler-ci Aug 17, 2018

stickler-ci Aug 17, 2018

stickler-ci Aug 17, 2018

stickler-ci Aug 17, 2018

stickler-ci Aug 17, 2018

stickler-ci Aug 17, 2018

stickler-ci Aug 17, 2018

stickler-ci Aug 17, 2018

stickler-ci Aug 17, 2018

stickler-ci Aug 17, 2018

stickler-ci Aug 17, 2018

stickler-ci Aug 17, 2018

stickler-ci Aug 17, 2018

coveralls commented Aug 17, 2018 •

edited

Loading

AaronV77 commented Aug 17, 2018

sdc50 commented Aug 17, 2018

AaronV77 commented Aug 20, 2018

dharhas commented Aug 20, 2018

AaronV77 commented Aug 20, 2018

sdc50 commented Aug 20, 2018

AaronV77 commented Aug 20, 2018

sdc50 commented Aug 20, 2018

		(math.pi - math.log(math.tan(math.pi / 4 + math.radians(lat) / 2))))

		return x, y

		return xmin_pixel, ymin_pixel, xmax_pixel, ymax_pixel


		@staticmethod

refactor basemap service and rename to wmts_imagery #100

refactor basemap service and rename to wmts_imagery #100

Conversation

sdc50 commented Aug 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Aug 17, 2018 • edited Loading

Pull Request Test Coverage Report for Build 347

💛 - Coveralls

AaronV77 commented Aug 17, 2018

sdc50 commented Aug 17, 2018

AaronV77 commented Aug 20, 2018

dharhas commented Aug 20, 2018

AaronV77 commented Aug 20, 2018

sdc50 commented Aug 20, 2018

AaronV77 commented Aug 20, 2018

sdc50 commented Aug 20, 2018

coveralls commented Aug 17, 2018 •

edited

Loading