Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2 Removal #107

Merged
merged 6 commits into from
Sep 7, 2018
Merged

Python 2 Removal #107

merged 6 commits into from
Sep 7, 2018

Conversation

AaronV77
Copy link
Collaborator

@AaronV77 AaronV77 commented Sep 4, 2018

Removed all the left over Python 2 support code from the code base. Also removed the noaa_ncep.py plugin from the source code as well.

@coveralls
Copy link

coveralls commented Sep 4, 2018

Copy link
Member

@sdc50 sdc50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but there are a few other python 2 things that need to be removed. Do a search for builtins and remove all imports (including in the main __init__.py. Also remove the __future__ import in that file.

@AaronV77
Copy link
Collaborator Author

AaronV77 commented Sep 6, 2018

Let the test run and this should be ready then. Thanks



class IoBase(with_metaclass(abc.ABCMeta, object)):
class IoBase(metaclass=abc.ABCMeta):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E999 SyntaxError: invalid syntax

@@ -35,7 +33,7 @@
reserved_feature_fields.extend(reserved_geometry_fields)


class ProviderBase(with_metaclass(abc.ABCMeta, object)):
class ProviderBase(metaclass=abc.ABCMeta):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E999 SyntaxError: invalid syntax

@sdc50 sdc50 merged commit 1fa4d25 into erdc:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants