-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 2 Removal #107
Python 2 Removal #107
Conversation
…_ncep plugin from the code base.
Pull Request Test Coverage Report for Build 385
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but there are a few other python 2 things that need to be removed. Do a search for builtins
and remove all imports (including in the main __init__.py
. Also remove the __future__
import in that file.
Let the test run and this should be ready then. Thanks |
|
||
|
||
class IoBase(with_metaclass(abc.ABCMeta, object)): | ||
class IoBase(metaclass=abc.ABCMeta): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E999 SyntaxError: invalid syntax
@@ -35,7 +33,7 @@ | |||
reserved_feature_fields.extend(reserved_geometry_fields) | |||
|
|||
|
|||
class ProviderBase(with_metaclass(abc.ABCMeta, object)): | |||
class ProviderBase(metaclass=abc.ABCMeta): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E999 SyntaxError: invalid syntax
Removed all the left over Python 2 support code from the code base. Also removed the noaa_ncep.py plugin from the source code as well.