Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update param #123

Merged
merged 3 commits into from
Dec 15, 2018
Merged

Update param #123

merged 3 commits into from
Dec 15, 2018

Conversation

sdc50
Copy link
Member

@sdc50 sdc50 commented Dec 12, 2018

Remove NamedString class since param now supports of mapping of names and objects for its selector classes.

self = str.__new__(cls, string)
self.name = name
return self
class AbstractParameterized(param.parameterized.ParameterMetaclass, ABCMeta): pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E701 multiple statements on one line (colon)



class DatasetSelector(param.ObjectSelector):
class QuestSelector(param.ObjectSelector, metaclass=AbstractParameterized):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E999 SyntaxError: invalid syntax

@coveralls
Copy link

coveralls commented Dec 14, 2018

Pull Request Test Coverage Report for Build 587

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 72 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 68.819%

Files with Coverage Reduction New Missed Lines %
/Users/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/quest/util/param_util.py 18 68.49%
/home/travis/miniconda/envs/test-environment/lib/python3.5/site-packages/quest/util/param_util.py 18 68.49%
/home/travis/miniconda/envs/test-environment/lib/python3.6/site-packages/quest/util/param_util.py 18 68.49%
/Users/travis/miniconda/envs/test-environment/lib/python3.5/site-packages/quest/util/param_util.py 18 68.49%
Totals Coverage Status
Change from base Build 566: -0.02%
Covered Lines: 4476
Relevant Lines: 6504

💛 - Coveralls

@AaronV77 AaronV77 merged commit beaca5c into erdc:master Dec 15, 2018
@sdc50 sdc50 deleted the update_param branch April 29, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants